Updates form_submission migration stubs to match the package migrations #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Laravel 10 & PHP 8.1 from testing matrix * Remove Testbench 8 version constraint * Require minimum of PHP 8.2
* Convert `$casts` property to method * Update example in the docs
# Conflicts: # .github/workflows/tests.yml # composer.json
* Drop `origin` column from `global_set_variables` column * Persist new `sites` option in global set options * Update existing tests There's still two failing tests locally, I'll get these fixed up tomorrow. * This test needs to be using multisite. * Not all tests require multisite. * Arr::get() is safer. * Update script * Fix styling * We shouldn't need to override this. * Sites and origins are now accessed using separate methods. * Update tests * Call `in` instead of `addLocalization` * Get rid of the GlobalFactory We're not using it anymore, and we've removed its equivelent in core. * Events are fired differently in v6. Remove test. --------- Co-authored-by: duncanmcclean <duncanmcclean@users.noreply.github.com>
…#431) * Allow globals and variables to be exported seperately * The origin is now defined on the global set * Change approach to export command * Update and add some tests thanks to Claude --------- Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
* Addon Settings * Fix styling * Require dev-addons for now * Fix export command test * wip * Allow referencing config options in settings * Avoid importing addons without settings * Some post-merge changes * Switch back to `master` --------- Co-authored-by: duncanmcclean <duncanmcclean@users.noreply.github.com>
The migration stubs currently don’t match the default migration files. Removed the 30 character limit on the `form` column in `form_submissions`. The `forms` table doesn’t have a limit set on `handle` so it’s possible to create a handle that can’t be stored in `form_submissions`.
|
Thanks for the PR - unfortunately you've targeted master not 4.x which is the default branch. |
|
Sorry about that, I had pushed code previously but didn't have any other branches locally. I must have done it through GitHub. I've create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After republishing the from migrations the character limit was removed resulting in a
varchar(255)string column.I kind of feel like there's no need to replicate this migration change in the packaged migrations since it's not presently there.
This fix should address anyone who's newly installed the package and who's freshly published the migrations.
closes #502