Fix robots meta ignoring new fields when legacy array exists#538
Merged
duncanmcclean merged 1 commit into7.xfrom Apr 17, 2026
Merged
Fix robots meta ignoring new fields when legacy array exists#538duncanmcclean merged 1 commit into7.xfrom
duncanmcclean merged 1 commit into7.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
robots_indexingandrobots_followingfields were ignored when the legacyrobotsarray was present in the cascade data.This was happening because
Cascade::robots()checked for the legacyrobotsarray first and returned early if it existed. In practice, this meant that if site defaults still had the oldrobots: [index, follow]format (e.g. from a v5 migration that was never re-saved), any explicitrobots_indexingorrobots_followingvalues set on an entry or localized site were silently ignored.This PR fixes it by reversing the priority in
Cascade::robots()— the newerrobots_indexing/robots_followingfields are now checked first. The legacyrobotsarray is only used as a fallback when none of the new fields are set.Fixes #535
Caused by #405
Caused by #441