Make argument test_kj required in emuFit() when run_score_tests = TRUE #118
Merged
adw96 merged 5 commits intostatdivlab:mainfrom Mar 14, 2025
Merged
Make argument test_kj required in emuFit() when run_score_tests = TRUE #118adw96 merged 5 commits intostatdivlab:mainfrom
test_kj required in emuFit() when run_score_tests = TRUE #118adw96 merged 5 commits intostatdivlab:mainfrom
Conversation
… note this in the vignette, and update tests to now use this behavior. Update the package version number to reflect this breaking change (non-backwards compatible) and add a news.md file to explain this and future version incrementations to users.
Collaborator
Author
|
@adw96 I updated the version to 2.0.0.0 (from 1.2.0.0) because this PR introduces breaking change, i.e. this is no longer backwards compatible with previous versions, which seems like criteria for a major release. However, if you'd prefer this to be considered a minor release (i.e. go from 1.2.0.0 to 1.3.0.0) let me know and I'll update that before merging this! |
Contributor
|
This is wonderful, @svteichman -- thank you for doing this! I think this will hugely improve the user experience. Thanks for taking the time to determine that this is a major release, too 🎩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updating
emuFit()so that whenrun_score_tests = TRUE, the argumenttest_kjis required instead of optional. Noting this in the vignette, and updating tests to now use this behavior. Updating the package version number to reflect this breaking change (non-backwards compatible) and adding a news.md file to explain this and future version incrementations to users.