Skip to content

Revert PR #87 merge#88

Merged
gabewillen merged 1 commit into
mainfrom
revert-pr-87
Jul 2, 2026
Merged

Revert PR #87 merge#88
gabewillen merged 1 commit into
mainfrom
revert-pr-87

Conversation

@gabewillen

@gabewillen gabewillen commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Reverts the merge of #87 (ee26ae8) — merged prematurely; the work will be resubmitted as a fresh PR for proper review.


Note

Medium Risk
Reverts shipped v1.27 x86_64 optimized kernel SML/documentation and deletes milestone audit artifacts, which can confuse planning truth and drop SIMD dispatch documentation until #87 is re-merged; Codex path changes break other machines unless reverted locally.

Overview
This reverts the merge of #87 (ee26ae8), which had landed prematurely; the intent is to resubmit that work in a fresh PR for review.

Planning and milestone narrative move backward: v1.27 Ryzen AVX2/FMA Kernel Support is removed from active PROJECT.md, STATE.md, ROADMAP.md, MILESTONES.md, and RETROSPECTIVE.md, and v1.26 I/O Staged Read is again treated as the current/completed milestone with v1.25 as latest shipped I/O. Large v1.26/v1.27 milestone archive files under .planning/milestones/ are deleted (audits, roadmaps, v1.27 requirements), and the top-level ROADMAP.md is expanded back to the long v1.26 phase ledger instead of the short “no active milestone” closeout.

Generated x86_64 kernel architecture (.planning/architecture/kernel_x86_64.md and mermaid) drops explicit SML transitions for AVX2 SIMD q2_K/q3_K/q6_K matmul and optimized flash-attention guards, matching a rollback of the v1.27 kernel routing story in docs.

.codex/config.toml changes every GSD agent config_file from a /shared/stateforward/emel.cpp/... path to a developer-local ~/VSCode/stateforward/emel/emel.cpp/... path (environment-specific, not product behavior).

Reviewed by Cursor Bugbot for commit a7ee719. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI review requested due to automatic review settings July 2, 2026 13:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@gabewillen gabewillen merged commit 8d1c232 into main Jul 2, 2026
1 check passed

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a7ee719. Configure here.

Comment thread .codex/config.toml
[agents.gsd-verifier]
description = "Verifies phase goal achievement through goal-backward analysis. Checks codebase delivers what phase promised, not just that tasks completed. Creates VERIFICATION.md report."
config_file = "/shared/stateforward/emel.cpp/.codex/agents/gsd-verifier.toml"
config_file = "/Users/gabrielwillen/VSCode/stateforward/emel/emel.cpp/.codex/agents/gsd-verifier.toml"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed developer absolute Codex paths

Medium Severity

The revert restores every GSD agent config_file entry to a fixed /Users/gabrielwillen/VSCode/stateforward/emel/emel.cpp/... absolute path instead of a portable repo location. Other clones and CI cannot resolve those paths, so Codex agent hooks fail outside that machine.

Fix in Cursor Fix in Web

Triggered by learned rule: No absolute local filesystem paths in committed files

Reviewed by Cursor Bugbot for commit a7ee719. Configure here.

Comment thread .planning/STATE.md
Last session: 2026-06-25 (v1.27 closeout)
Stopped at: v1.27 shipped and archived; ready for the next milestone.
Last session: 2026-05-08 (v1.26 milestone audit and gap-closure phase creation)
Stopped at: Phase **237** ready for discuss/plan/execute.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATE claims complete yet resumes Phase 237

Medium Severity

After this revert, STATE.md frontmatter and body assert v1.26 is 100% complete with a passed audit and no pending phases, while Current focus still says to define and execute v1.26, and Session continuity stops at Phase 237 ready for discuss/plan/execute. Automation that reads resume pointers gets conflicting next steps.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a7ee719. Configure here.

Comment thread .planning/PROJECT.md
Stateforward.SML actor for constrained-memory chunked/staged tensor loads,
integrated through the existing tensor-to-I/O boundary from issue #60, without
moving tensor residency ownership out of `model/tensor` and without cooperative
coroutine scheduling unless separately approved.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROJECT omits shipped v1.26 milestone

Medium Severity

This revert sets Current milestone to in-progress v1.26 and Latest shipped milestone to v1.25, while the same commit’s STATE.md, ROADMAP.md, and retained v1.26-MILESTONE-AUDIT.md describe v1.26 as complete with a passed audit. Maintainers get contradictory milestone truth from official planning files.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a7ee719. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants