Back-End HTML Bugfixes and Accessibility Improvements#6
Merged
MarcFraile merged 4 commits intostatgen-custom-changesfrom Apr 16, 2026
Merged
Back-End HTML Bugfixes and Accessibility Improvements#6MarcFraile merged 4 commits intostatgen-custom-changesfrom
MarcFraile merged 4 commits intostatgen-custom-changesfrom
Conversation
…extflowProcessRenderer.
…ot found (by throwing FileNotFoundException)
… class; fix breaking typo in progressbar.html; related cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the separation of front-end and back-end, we deleted some HTML templates that seemed unused.
It turns out
NextflowProcessRendereruses them to include representational HTML as part of a larger informational JSON bundle when callingGET /api/v2/jobs/<job-id>(horrible design, but that's beside the point).Without the templates, the untested template rendering methods were failing silently and returning an empty string, so nothing panicked, but no information was displayed in the front-end UI at all.
This PR re-adds the missing templates, adds
NextflowProcessRendererTestwith thorough testing to avoid similar situations in the future, and improves accessibility compliance inprogressbar.html.