Skip to content

Mixins#182

Merged
jescalan merged 4 commits intostatic-dev:masterfrom
abstracthat:master
Jun 4, 2015
Merged

Mixins#182
jescalan merged 4 commits intostatic-dev:masterfrom
abstracthat:master

Conversation

@abstracthat
Copy link
Copy Markdown
Contributor

Here's the mixins we discussed previously. Sorry it took a little while, I've been swamped.

  • border-box-html()
  • fluid-media()
  • ratio-box()
  • print-styles()

@dbox
Copy link
Copy Markdown
Collaborator

dbox commented May 25, 2015

👍

@jescalan
Copy link
Copy Markdown
Member

jescalan commented Jun 4, 2015

Fantastic, thanks so much @abstracthat! This is great. Is there any chance you'd be willing to add examples of this to axis-www when you have a moment?

jescalan pushed a commit that referenced this pull request Jun 4, 2015
@jescalan jescalan merged commit 61cc7b9 into static-dev:master Jun 4, 2015
@dbox
Copy link
Copy Markdown
Collaborator

dbox commented Jun 4, 2015

If you don't want to @abstracthat I can. I have to add several things anyway.

@Jenius I assume we need a new build released before I can add to axis-www. I'm happy to do, just need to know how you want to version it. Should we go 0.4.0?

@jescalan
Copy link
Copy Markdown
Member

jescalan commented Jun 4, 2015

Sounds good. Yeah, do you want to try cutting the release now that you are on core? Here's my general process --

  1. Run npm version x.x.x with whatever version you want to go to. This will push a commit upping the package.json number and a git tag.
  2. Run git push && git push --tags to push the version bump commit and the tag to github
  3. In the releases tab, add the release notes and info
  4. Run npm publish . to publish to npm
  5. 🎉 🎊

@dbox
Copy link
Copy Markdown
Collaborator

dbox commented Jun 4, 2015

Sounds easy enough. Will do. Bear with me if I make any mistakes. :)

@dbox
Copy link
Copy Markdown
Collaborator

dbox commented Jun 4, 2015

Everything was smooth until step 4 which gave me this:

https://www.dropbox.com/s/qmjserq4ulbo6li/Screenshot%202015-06-04%2009.56.16.png?dl=0

Is this a permissions thing?

@jescalan
Copy link
Copy Markdown
Member

jescalan commented Jun 4, 2015

Yup sorry my bad. Just added you, try again!

@dbox
Copy link
Copy Markdown
Collaborator

dbox commented Jun 4, 2015

Bingo! We're at 0.4.0. Go team!

I'll do the site updates this weekend. @abstracthat Just let me know if you want me to add your stuff. Happy to do, or if you want to, totally fine too.

@jescalan
Copy link
Copy Markdown
Member

jescalan commented Jun 4, 2015

My man! ✋

@hhsnopek
Copy link
Copy Markdown

hhsnopek commented Jun 4, 2015

🎊 Yay!

@abstracthat
Copy link
Copy Markdown
Contributor Author

I added a PR for these mixins and also bumped the axis version in axis-www. Thanks for getting this stuff out there guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants