-
Notifications
You must be signed in to change notification settings - Fork 45
Remove Nib #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Nib #210
Conversation
- remove 'pie' entirely - remove leftover vertical rhythm variables from settings - remove unneeded vendor mixins - clean up formatting in settings file - fix gradient syntax
- BREAKING: "media" changed to "media-object" due to AP conflict - clearfix reintroduced as a cleaner version that does not support IE 6 or 7, because nobody supports these browsers anymore
|
Wow rad. Wife just had a baby, so will follow up soonish. |
|
Woah, congrats man! This is amazing! 🎉 👶 You gotta post a photo in this issue thread, it will be amazing |
|
Best PR discussion ever. Congrats again, this is the cutest baby! My girlfriend would like me to also let you know that "Elliott is a cutie bear". 👶 |
|
This is great stuff |
|
The baby, that is. the PR IS JUNK. |
|
Okay, renamed him to Axis Stylus Border Box. |
|
Congratz @dbox ! 👶 |
|
Thanks everyone. We're home now and I have him learning some basic HTML markup – hopefully he'll be able to start pulling his weight on Axis soon. @Jenius This PR is incred and i'm super stoked on it. |
|
At very least his middle name should be axis |
|
Wow, tests run way faster now for me now.
Let me know what you want help with @Jenius. |
|
Okay, added |
|
Great, all these changes look good. I'll pull down and take another sweep of this soon! |
|
Ok sorry for the delay, I'm going to take another pass on this in the next couple of days and try to get this merged up. Whoo! 🎉 |
|
Ok I'm feeling good about this. All tests passing, visual tests look good. Anyone want to take a final look at this before we merge up? cc @declandewet @dbox Also, we need a description of what changes were made here. I'm going to start working on this right now. Note: Does anyone use nib's |
ChangelogIn this release, we removed nib as a dependency. Why? First, nib is unmaintained, with enormous numbers of open issues and ignored pull requests. And second, nib still includes extra code for older browsers, code that is now very outdated and adds a bunch of unnecessary weight to the output. This capability is much better handled by autoprefixer. As such, axis now ships with zero cross-browser support. It produces only bare minimum css3 spec compliant code. You can and should use autoprefixer to ensure that your code works correctly across the range of browsers you need it to work with. We did re-implement a number of the useful functions from nib, including:
The only pieces from nib that were not included are:
This is a large breaking change, hence the minor version bump (see our pre-1.0 versioning policy). Use caution before running this upgrade on a live site, and if you do make sure to thoroughly check all pages and ensure they are still looking good. |
|
Yay! I can't dive into this tonight (sleep is so precious right now), but this looks awesome. I say we just plaster warnings all over the release and go for it. Going to be hard to truly see what all breaks until we pull it into a live site. (Clearly we can start with axis-www.) I will have several updates ready to go as soon as this version ships, so I'll be available to quickly help patch anything that may need fixing. Thanks for pulling it all together @Jenius! I <3 Axis. |
|
Okay, I did find one more reference to nib: readme.md. |
|
Agreed. Updated the readme too. Ok, so I'm about to ship this out. Whoo! 🎉 That being said, we do have a decent amount of work to do once this has shipped. Mostly in updates to axis-www. I'll get started on this today, of course would appreciate any help, but I know you are in 👶 town, so don't even think about taking any time to do this unless you are relaxed and well-rested 😀 |
|
Published as |
|
Whooo! Awesome! I'll be able to help on axis-www. Traveling this week too,
|

Ref #192
Not yet complete, but the majority of the work has been done here and tests are passing. Still needs touchups, a couple more tools imported from nib, and some adjustments to the visual test results.
We also need a summary of all the breaking changes somewhere, which is going to be rather large.
On the plus side, the code is significantly lighter, cleaner, and better. Whoo! 🎉