Skip to content

Conversation

@jescalan
Copy link
Member

Ref #192

Not yet complete, but the majority of the work has been done here and tests are passing. Still needs touchups, a couple more tools imported from nib, and some adjustments to the visual test results.

We also need a summary of all the breaking changes somewhere, which is going to be rather large.

On the plus side, the code is significantly lighter, cleaner, and better. Whoo! 🎉

Jeff Escalante added 9 commits August 18, 2015 23:59
- remove 'pie' entirely
- remove leftover vertical rhythm variables from settings
- remove unneeded vendor mixins
- clean up formatting in settings file
- fix gradient syntax
- BREAKING: "media" changed to "media-object" due to AP conflict
- clearfix reintroduced as a cleaner version that does not support
  IE 6 or 7, because nobody supports these browsers anymore
@dbox
Copy link
Collaborator

dbox commented Aug 19, 2015

Wow rad. Wife just had a baby, so will follow up soonish.

@zspecza
Copy link
Contributor

zspecza commented Aug 19, 2015

congrats @dbox :) 👶 🍼

Nice work, @Jenius

@jescalan
Copy link
Member Author

Woah, congrats man! This is amazing! 🎉 👶

You gotta post a photo in this issue thread, it will be amazing

@dbox
Copy link
Collaborator

dbox commented Aug 19, 2015

image

Elliott

@jescalan
Copy link
Member Author

Best PR discussion ever. Congrats again, this is the cutest baby! My girlfriend would like me to also let you know that "Elliott is a cutie bear".

👶

@kylemac
Copy link

kylemac commented Aug 20, 2015

This is great stuff

@kylemac
Copy link

kylemac commented Aug 20, 2015

The baby, that is. the PR IS JUNK.

@dbox
Copy link
Collaborator

dbox commented Aug 20, 2015

Okay, renamed him to Axis Stylus Border Box.

@hhsnopek
Copy link

Congratz @dbox ! 👶

@dbox
Copy link
Collaborator

dbox commented Aug 20, 2015

Thanks everyone. We're home now and I have him learning some basic HTML markup – hopefully he'll be able to start pulling his weight on Axis soon.

@Jenius This PR is incred and i'm super stoked on it.

@jescalan
Copy link
Member Author

At very least his middle name should be axis

@dbox
Copy link
Collaborator

dbox commented Aug 21, 2015

Wow, tests run way faster now for me now.

Still needs touchups, a couple more tools imported from nib, and some adjustments to the visual test results.

Let me know what you want help with @Jenius.

@dbox
Copy link
Collaborator

dbox commented Aug 21, 2015

Okay, added global-reset,shadow-stroke, ellipsis and cleaned up a few things. Only thing I see missing from our original list is nib's border-radius. I could probably figure it out but not dying for it...

@jescalan
Copy link
Member Author

Great, all these changes look good. I'll pull down and take another sweep of this soon!

@dbox dbox mentioned this pull request Aug 24, 2015
@jescalan
Copy link
Member Author

Ok sorry for the delay, I'm going to take another pass on this in the next couple of days and try to get this merged up. Whoo! 🎉

@jescalan
Copy link
Member Author

Ok I'm feeling good about this. All tests passing, visual tests look good. Anyone want to take a final look at this before we merge up? cc @declandewet @dbox

Also, we need a description of what changes were made here. I'm going to start working on this right now.

Note: Does anyone use nib's image mixin? Do we already have an equivalent version?

@jescalan
Copy link
Member Author

Changelog

In this release, we removed nib as a dependency. Why? First, nib is unmaintained, with enormous numbers of open issues and ignored pull requests. And second, nib still includes extra code for older browsers, code that is now very outdated and adds a bunch of unnecessary weight to the output. This capability is much better handled by autoprefixer.

As such, axis now ships with zero cross-browser support. It produces only bare minimum css3 spec compliant code. You can and should use autoprefixer to ensure that your code works correctly across the range of browsers you need it to work with.

We did re-implement a number of the useful functions from nib, including:

  • global-reset and all it's nested pieces
  • position mixins (absolute, relative, and fixed)
  • clearfix (although we recommend group instead)
  • overflow: ellipsis

The only pieces from nib that were not included are:

  • image (use bg-image instead, better mixin with a clearer name)
  • border-radius (not judged to be frequently used)
  • gradients (now just use css3 spec gradients and autoprefixer)
  • all vendor prefixes properties

This is a large breaking change, hence the minor version bump (see our pre-1.0 versioning policy). Use caution before running this upgrade on a live site, and if you do make sure to thoroughly check all pages and ensure they are still looking good.

@jescalan jescalan changed the title [WIP] Remove Nib Remove Nib Sep 12, 2015
@dbox
Copy link
Collaborator

dbox commented Sep 13, 2015

Yay! I can't dive into this tonight (sleep is so precious right now), but this looks awesome.

I say we just plaster warnings all over the release and go for it. Going to be hard to truly see what all breaks until we pull it into a live site. (Clearly we can start with axis-www.)

I will have several updates ready to go as soon as this version ships, so I'll be available to quickly help patch anything that may need fixing.

Thanks for pulling it all together @Jenius! I <3 Axis.

@dbox
Copy link
Collaborator

dbox commented Sep 13, 2015

Okay, I did find one more reference to nib: readme.md.

@jescalan
Copy link
Member Author

Agreed. Updated the readme too.

Ok, so I'm about to ship this out. Whoo! 🎉 That being said, we do have a decent amount of work to do once this has shipped. Mostly in updates to axis-www. I'll get started on this today, of course would appreciate any help, but I know you are in 👶 town, so don't even think about taking any time to do this unless you are relaxed and well-rested 😀

jescalan pushed a commit that referenced this pull request Sep 14, 2015
@jescalan jescalan merged commit 0ebb7e0 into master Sep 14, 2015
@jescalan jescalan deleted the remove-nib branch September 14, 2015 11:39
@jescalan
Copy link
Member Author

Published as axis@0.5.0 🎉

@dbox
Copy link
Collaborator

dbox commented Sep 14, 2015

Whooo! Awesome! I'll be able to help on axis-www. Traveling this week too,
but I'll squeeze in some time.
On Mon, Sep 14, 2015 at 6:55 AM Jeff Escalante notifications@github.com
wrote:

Published as axis@0.5.0 [image: 🎉]


Reply to this email directly or view it on GitHub
#210 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants