Skip to content

breadcrumb test for #198 plus open-type-ligature test fix#232

Merged
jescalan merged 1 commit intomasterfrom
janviehweger-master
Nov 3, 2015
Merged

breadcrumb test for #198 plus open-type-ligature test fix#232
jescalan merged 1 commit intomasterfrom
janviehweger-master

Conversation

@dbox
Copy link
Copy Markdown
Collaborator

@dbox dbox commented Nov 1, 2015

This pulls in #198 and adds tests

@dbox
Copy link
Copy Markdown
Collaborator Author

dbox commented Nov 1, 2015

failed tests whatttt

@dbox
Copy link
Copy Markdown
Collaborator Author

dbox commented Nov 1, 2015

@Jenius i think there is some difference in the local test and travis tests. for whatever reason the local one wanted -moz-font-feature-settings: "liga", "dlig"; added to open-type-ligatures. It passes all tests locally.

@jescalan
Copy link
Copy Markdown
Member

jescalan commented Nov 3, 2015

hmm that is pretty strange. did you clear and reinstall all the deps locally too I assume?

@dbox
Copy link
Copy Markdown
Collaborator Author

dbox commented Nov 3, 2015

remove node_modules and new npm install seems to have worked. I'll try to squash this up

@dbox dbox force-pushed the janviehweger-master branch from 12c962f to f81bfe4 Compare November 3, 2015 15:35
@dbox
Copy link
Copy Markdown
Collaborator Author

dbox commented Nov 3, 2015

Squashed up. Should be safe to merge this one and close #198

jescalan pushed a commit that referenced this pull request Nov 3, 2015
breadcrumb test for #198 plus open-type-ligature test fix
@jescalan jescalan merged commit db1454f into master Nov 3, 2015
@jescalan jescalan deleted the janviehweger-master branch November 3, 2015 19:27
@jescalan
Copy link
Copy Markdown
Member

jescalan commented Nov 3, 2015

Whoo! Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants