Skip to content

Conversation

@dbox
Copy link
Collaborator

@dbox dbox commented Feb 24, 2016

addresses #243, #255, & #261

@dbox dbox changed the title Misc cleanpu Misc cleanup Feb 24, 2016
@jescalan
Copy link
Member

lgtm 👍

jescalan pushed a commit that referenced this pull request Feb 24, 2016
@jescalan jescalan merged commit 2f1bd2c into master Feb 24, 2016
@jescalan jescalan deleted the 243-255-261 branch February 24, 2016 03:33
@dbox
Copy link
Collaborator Author

dbox commented Feb 24, 2016

You want me to version up and publish?

@jescalan
Copy link
Member

yeah! make the magic happen ✨

@dbox
Copy link
Collaborator Author

dbox commented Feb 24, 2016

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "approvals/lgtm" is expected
To https://github.com/jenius/axis.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/jenius/axis.git'

looks like the LGTM is blocking me from doing so

@jescalan
Copy link
Member

haha god damn I honestly have no idea how to get rid of that service it's so annoying

@dbox
Copy link
Collaborator Author

dbox commented Feb 24, 2016

I thought you set it up to keep the reigns on me!

@jescalan
Copy link
Member

Haha not at all, just wanted to test it out. But it totally doesn't work. I think I just turned it off, try again?

@dbox
Copy link
Collaborator Author

dbox commented Feb 24, 2016

same error

@jescalan
Copy link
Member

😠

@dbox
Copy link
Collaborator Author

dbox commented Feb 24, 2016

slack-imgs com

@jescalan
Copy link
Member

Ok I think I really got it this time. One more shot?

@dbox
Copy link
Collaborator Author

dbox commented Feb 24, 2016

bingo 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants