Unable to package because `node_modules`

[nyurik]

The martin porject currently fails to publish to crates.io because the build.rs downloads the node_modules/** to a directory that is not part of the OUT_DIR as required by cargo. Changing .target(...) to use OUT_DIR only fixes the generated file location, but not the location of the node_modules. Adding things to exclude do not seem to help. Is there a way to do this?

cargo package -p martin --dry-run fails because

error: failed to verify package tarball
 450   │
 451   │ Caused by:
 452   │   Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
 453   │   Added: .../martin/target/package/martin-0.15.0/martin-ui/dist
 454   │     .../martin/target/package/martin-0.15.0/martin-ui/dist/_
                      ....

P.S. cross-posted to stackoverflow

[kilork]

As w/a you can add flag --no-verify to publish command. Strange cargo does not allow to change things in git ignored folder.

[nyurik]

@kilork thx, Cargo did mention it - but I suspect this might cause all sorts of problems, i.e. if someone uses it as a dependency, it may place some non-published files directly in the ~/.cargo/registry/cache - which probably is not a very good situation - i.e. caching things in a place where things shouldn't be cached.

[kilork]

@nyurik I do not think so. By default git ignored entries are not included (unless you specify include). You can verify it with 'cargo package --list'

[nyurik]

i wonder if build.rs should simply delete the node_modules once it generated the file? and rely on npm to do some global caching?

[kilork]

It looks like publish creates a copy of source tree in target directory. And then tracks files in there. If files are not inside of target folder, it fails. We should adopt our process to having this as primary scenario, I think.

Removing the node_modules would work, but we probably should do this only if we are in running inside of publish command.

https://stackoverflow.com/questions/14742553/how-to-set-custom-location-for-local-installation-of-npm-package

Seems like setting proper NPM_CONFIG_PREFIX environment variable should do the trick.

[kilork]

Seems like setting proper NPM_CONFIG_PREFIX environment variable should do the trick.

No, it does not. I assume we have to delete node_modules and give option to not clean this if it is not desired.

In debug mode it should not remove things until it is forced, only in release profile.

What do you think @nyurik ?

[kilork]

@nyurik I implemented first draft version, can you check, if it works for you?

[kilork]

@nyurik ping?

[nyurik]

hi @kilork sorry was away for a bit (conference), and it kinda slipped. Seems @CommanderStorm reviewed it already. Thx for working on this!