Fix: Sanitize the pagination parameters#136
Merged
dstpierre merged 2 commits intostaticbackendhq:mainfrom Mar 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Sanitized the pagination parameters in
getPagination()(db.go) to clamppageandsizeto a minimum value of 1 when 0 or negative values are provided.Why
When 0 is sent as the page number (e.g., from the Go client library which sends 0 as the default int value), an EOF error is returned. Similarly, a size of 0 or negative values could cause unexpected behavior.
Fixes #135
Testing
Added
TestGetPaginationSanitizesValuesindb_test.gowith table-driven subtests covering:All existing tests continue to pass.