Create Playwright test harness #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
fhinkel
reviewed
Jun 29, 2022
fhinkel
reviewed
Jun 29, 2022
fhinkel
reviewed
Jun 29, 2022
fhinkel
suggested changes
Jun 29, 2022
Contributor
fhinkel
left a comment
fhinkel
left a comment
There was a problem hiding this comment.
Thank you! 👏
We should include Node18 and use v3 for checkout and setup-node.
For the PR title, I'd prefer imperative present tense, e.g., Create Playwright test harness. That's inline with the commit history and common best practice, see https://365git.tumblr.com/post/3308646748/writing-git-commit-messages
fhinkel
approved these changes
Jun 29, 2022
HannahZhuSWE
changed the title
Contributor
|
@manekinekko can you look into why the CI is not running on this PR please? |
manekinekko
reviewed
Jun 30, 2022
|
Thank you @HannahZhuSWE for your contribution. I left a comment to change the workflow setting for the CI to run on every branch and PR. |
Contributor
Author
|
Thank you Wassim! |
Contributor
Author
|
@fhinkel I implemented all the suggestions for this PR |
Contributor
|
|
Contributor
|
As discussed, this is not running because the PR is form a fork. I think we can merge this as it's green on your fork. |
fhinkel
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a playwright test harness and github action that runs the tests on push and pull requests to the main branch and at midnight. Tests can be run with
npm run playwright_test. Note in order to run playwright a package.json file and start script was created.