Changing plotly newplot to plotly react. #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
indeed like mentioned in #10 |
|
@statnett @gwdekker @wendelborg any update on this? |
Contributor
|
This PR broke the tests, the referenced commit also fixes tests. Data need to be immutable or datarevision need to be set. I chose the latter approach in watch handler for data. |
amfine-soft-drault
added a commit
to amfine-soft-jguillin/vue-plotly
that referenced
this pull request
Nov 29, 2019
* upstream/master: 0.3.2 Using react for resize event 0.3.1 Replace all usages of newPlot Formatting Formatting 0.3.0 Build for custom png export Add afterplot event. Closes statnett#13 Use react instead of newPlot to redraw. Closes statnett#11 toImageButton defaults to 700x450 - ignoring container width/height. this change sets the width/height to be the same size as the current plotly container size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Plot is expensive and discards event handlers, react is a better option.