Skip to content

Study Case Editing#114

Merged
dan-tang-ssd merged 8 commits intodevfrom
study-case-editing
Sep 9, 2025
Merged

Study Case Editing#114
dan-tang-ssd merged 8 commits intodevfrom
study-case-editing

Conversation

@dan-tang-ssd
Copy link
Copy Markdown
Member

@dan-tang-ssd dan-tang-ssd commented Sep 8, 2025

This PR is submitted to fix #102

It is not yet ready for review. It is submitted for progress update.


It contains below changes:

  • set status to "Proposal" for newly created study case
  • for Proposal stage cases, hide leading organisation and partner orgs section
  • remove status Ready for Development and related code; add status Closed
  • StudyCaseResurce, add code for "Further Develop" and "Close"
  • admin panel > StudyCaseResource, add filter for status
  • admin panel > StudyCaseResource, do not show study case with status "Closed" by default
  • StudyCaseResource, hide Confirmation page (or not adding it) when status is "Proposal"

@dan-tang-ssd
Copy link
Copy Markdown
Member Author

This PR contains changes as listed except the last one.

I think it is now ready to merge.


TODO:

  • StudyCaseResource, hide Confirmation page (or not adding it) when status is "Proposal"
    • Question: in StudyCaseResource.getRecordSubNavigation(), how do we access the current study_cases record to add confirmation page if status is not "proposal"?

Screen shots:

App panel, not sure how to hide (or not adding) confirmation page for study cases with status "proposal". It is a compromise to show a message to indicate this study case is now pending on reviewer to review
image

Admin panel, apply default filter to hide study cases with "closed" status
image

Admin panel, filter study cases with "proposal" status
image

Admin panel, filter study cases with "closed" status, no cases is showed because the default filter to hide "closed" status is ticked
image

Admin panel, untick default filter to show study case with "closed" status
image

@dave-mills
Copy link
Copy Markdown
Member

Question: in StudyCaseResource.getRecordSubNavigation(), how do we access the current study_cases record to add confirmation page if status is not "proposal"?

The getRecordSubNavigation() method receives a Page object - which is the current page. That is how the function knows what navigation items to generate (i.e. it knows that when you're editing StudyCase with ID = 1, it should generate links to the other pages for ID = 1.)

So, we can use that Page object to check the current StudyCase properties. See my latest commit

@dan-tang-ssd
Copy link
Copy Markdown
Member Author

Thank you Dave.

I will merge this PR now.

@dan-tang-ssd dan-tang-ssd merged commit 37d153c into dev Sep 9, 2025
@dan-tang-ssd dan-tang-ssd deleted the study-case-editing branch September 9, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Study Case Editing

2 participants