Skip to content

DOC: Fix contradicting KPSS-statistics interpretations in stationarity_detrending_adf_kpss.ipynb#7090

Merged
bashtage merged 1 commit intostatsmodels:masterfrom
mzietlow:DOC_contradicting_KPSS_interpretations
Oct 9, 2020
Merged

DOC: Fix contradicting KPSS-statistics interpretations in stationarity_detrending_adf_kpss.ipynb#7090
bashtage merged 1 commit intostatsmodels:masterfrom
mzietlow:DOC_contradicting_KPSS_interpretations

Conversation

@mzietlow
Copy link
Copy Markdown
Contributor

@mzietlow mzietlow commented Oct 9, 2020

Details

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@mzietlow mzietlow changed the title DOC: Fix contradicting KPSS-statistics interpretations in example DOC: Fix contradicting KPSS-statistics interpretations in stationarity_detrending_adf_kpss.ipynb Oct 9, 2020
@bashtage
Copy link
Copy Markdown
Member

bashtage commented Oct 9, 2020

Perfect. Thanks.

@bashtage bashtage merged commit ee82a0d into statsmodels:master Oct 9, 2020
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 88.408% when pulling fa9f348 on mzietlow:DOC_contradicting_KPSS_interpretations into dc9d80a on statsmodels:master.

This was referenced Oct 27, 2020
@bashtage bashtage removed the backport label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: KPSS interpretation in stationarity_detrending_adf_kpss.ipynb

3 participants