Only call message callback in bidirectional streams (et al) #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message processing hook is intended for handling notifications /
requests from the server which can happen with for example websockets
and other bidirectional transports.
When using the HTTP endpoint, the server does not really have the
opportunity to send anything except the response since the connection is
unidirectional.
* don't call processing hook for http endpoint
* make raised exceptions more accurate with respect to spec
* `InvalidRequest` -> `ApplicationError`, deprecate former name
* one less copy of parameters in rpc macro code
* more strict handling of missing / null fields in jrpc_sys
* differentiate between `null` and "not present" id in requests
* allow `null` request id ("not present"/notifications TODO!)
* don't allow `null` parameter list - allow a non-present one
* stop parsing earlier when `jsonrpc` tag is missing/wrong
* restore some backwards compat with web3, broken in #247
* discard empty batches earlier
* remove unused `RequestBatchTx`/`ResponseBatchTx` * streamline jrpc_sys tests
jangko
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message processing hook is intended for handling notifications / requests from the server which can happen with for example websockets and other bidirectional transports.
When using the HTTP endpoint, the server does not really have the opportunity to send anything except the response since the connection is unidirectional.
InvalidRequest->ApplicationError, deprecate former namenulland "not present" id in requestsnullrequest id ("not present"/notifications TODO!)nullparameter list - allow a non-present onejsonrpctag is missing/wrong