-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(wallet)_: Add status network sepolia #22267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (8)
|
604d008 to
363821c
Compare
mohsen-ghafouri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, It looks good to me and is a great documentary to have when adding a new network to the code.
|
hi @smohamedjavid Could you please rebase PR and status go PR? Thanks! |
363821c to
259c792
Compare
35% of end-end tests have passedFailed tests (41)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestFallbackMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedThree:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestWalletCollectibles:
Passed tests (24)Click to expandClass TestFallbackMultipleDevice:
Class TestAndroid13:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestAndroid12:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
|
|
hi @smohamedjavid Thank you for PR. No issues from my side. PR is ready to be merged
|
|
@smohamedjavid should we merge this PR? |
|
@clauxx - we need one additional approval to merge the status-go PR status-im/status-go#6393 to merge, after that, I will merge this PR 🙏 |
|
Just additional info for previous test notes in the comment. Connection is not tested within the current PR due to the lack of a test dApp that supports the Status Sepolia network |
status-im/status-go@fa7db6f...2d5eaef Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
259c792 to
9dbcc12
Compare
fixes #22202
Summary
This PR adds Status Network Sepolia.
Uses status-go PR: status-im/status-go#6393
Status-Network-Sepolia.mp4
Testing notes
Network details | Faucet | Bridge
Platforms
Areas that may be impacted
Functional
Steps to test
status: ready