feat: add interact key fishing mode support#12
Merged
Conversation
Implement configurable interact key mode as alternative to mouse-based fishing: - Add UseInteractKey and KeyboardKeyInteract config properties - Update ConfigValidator to validate interact key requirements - Modify FishingStateMachine to skip FindBobber state when using interact mode - Replace mouse right-click with configured interact key in CatchFish state - Update audio detection to work without bobber detection in interact mode - Add comprehensive logging for both traditional and interact modes - Update CLAUDE.md with interact key feature documentation Addresses issue #2 - provides bot-detection-safer alternative by eliminating mouse movement patterns while maintaining audio-based fish detection.
- Change KeyboardKeyInteract to non-nullable with default 'f' - Remove validation requirement since default is always provided - Remove null-forgiving operator in state machine - Follows same pattern as other keyboard bindings in codebase
- Modify KeyboardUtils to send lowercase letters without braces - Keep braces for special keys (numbers, etc.) but use direct send for letters - Reduce log spam by increasing threshold from 0.01f to 0.05f - Increase log interval from 2 seconds to 5 seconds - Should fix capital F issue in WoW chat window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technical Implementation
Configuration Options:
State Machine Changes:
CastLine→WaitAndCatch(skipsFindBobberwhen interact mode enabled)CatchFishusesKeyboardUtils.SendKeyInput()instead ofMouseUtils.SendMouseInput()Validation:
KeyboardKeyInteractrequired whenUseInteractKeyis enabledTest Plan
Closes #2