Refinements#30
Merged
Merged
Conversation
- cmake: guard /MP flag to cl.exe only (clang-cl doesn't support it) - cmake: add clang-cl-specific warning suppressions (-Wno-unknown-attributes, -Wno-unused-parameter/variable, propagate CLANG_WARNINGS -Wno-* flags) - benchmark: add required 's' suffix to --benchmark_min_time (v1.9.1 API) - topological_sort: convert recursive DFS to iterative to fix stack overflow on deep graphs (e.g. 10000-vertex path DAG in BM_TopoSort benchmark) - Broad warning cleanup across views, algorithms, generators, io, tests, and examples for clang-cl compatibility (unused params, unqualified std::move/forward, etc.)
…ress GCC -Wdangling-reference GCC 15 incorrectly flags the uid parameter in basic_incidence() and basic_out_incidence() as a dangling reference when used in a range-for structured binding. Since vertex_id_t is always a cheap integer or map key type, passing by value is correct and suppresses the false positive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.