feat: add utils/every-own-by
#1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/node_modules/@stdlib/utils/every-own-by/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/utils/every-own-by/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/utils/every-own-by/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
Planeshifter
changed the title
utils/every-own-by
|
@Planeshifter I have done the changes and also fixed benchmark.jl file can you review this PR ? |
Planeshifter
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/utils/every-own-by/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/utils/every-own-by/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/utils/every-own-by/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
reviewed
Mar 3, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
@PraneGIT Thanks! Looked good overall, but there were a bunch of small documentation fixes that had to be made. Will merge once CI has passed. |
Planeshifter
approved these changes
Mar 3, 2024
kgryte
reviewed
Mar 6, 2024
There was a problem hiding this comment.
@Planeshifter Why was a Julia benchmark added to this package? Julia has no equivalent functionality. This was copied from utils/every, but is not appropriate here.
bad-in-coding
pushed a commit
to bad-in-coding/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1413 Closes: stdlib-js#818 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Aditya Sapra <110766802+adityacodes30@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #818.
Description
adds Package: @stdlib/utils/every-own-by
This pull request:
Related Issues
This pull request:
@stdlib/utils/every-own-by#818Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers