Skip to content

Conversation

@rajutkarsh07
Copy link
Contributor

@rajutkarsh07 rajutkarsh07 commented Mar 27, 2024

Resolves #1487 .

Description

update blas/ext/base/dnansumpw to follow current project conventions

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 27, 2024
@rajutkarsh07
Copy link
Contributor Author

@Pranavchiku @Planeshifter please review this PR

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 28, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

One of the dependencies was missing in manifest.json. Please remember to run tests, benchmarks, and examples locally to make sure things work properly.

Will merge once all CI checks are green.

@Planeshifter Planeshifter merged commit 87ccb3b into stdlib-js:develop Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnansumpw to follow current project conventions

3 participants