Skip to content

Conversation

@aman-095
Copy link
Member

Description

This RFC proposes to add a routine to find the index of the first element having maximum absolute value as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/isamax is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 11, 2024
@Pranavchiku
Copy link
Member

This will be simple to review, I'll review this and idamax today evening ( IST )

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Fortran Issue involves or relates to Fortran. C Issue involves or relates to C. labels Apr 12, 2024
@Pranavchiku
Copy link
Member

Can you please iterate over changes made in idamax and see if this PR has anything to change?

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095.

Note that I had to make a number of small changes. So would be worthwhile on your side to do a file-by-file review to minimize typos, etc, in future PRs, especially when porting changes from one PR to another, as in the BLAS work.

@kgryte kgryte merged commit fb6571e into stdlib-js:develop Apr 20, 2024
@aman-095
Copy link
Member Author

Sure, @kgryte will review all the files once before pushing. Thanks for reviewing and merging this PR. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Fortran Issue involves or relates to Fortran. Native Addons Issue involves or relates to Node.js native add-ons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants