-
-
Notifications
You must be signed in to change notification settings - Fork 996
feat: add blas/base/isamax
#2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will be simple to review, I'll review this and |
|
Can you please iterate over changes made in |
…/aman-095/2153
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @aman-095.
Note that I had to make a number of small changes. So would be worthwhile on your side to do a file-by-file review to minimize typos, etc, in future PRs, especially when porting changes from one PR to another, as in the BLAS work.
|
Sure, @kgryte will review all the files once before pushing. Thanks for reviewing and merging this PR. |
Description
This RFC proposes to add a routine to find the index of the first element having maximum absolute value as defined in BLAS Level 1 routines. Specifically adding
@stdlib/blas/base/isamaxis proposed.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers