Skip to content

Conversation

vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Dec 5, 2024

Resolves #3344

Description

What is the purpose of this pull request?

This pull request:

  • This RFC proposes adding the package @stdlib/constants/float32/ln-pi returning natural logarithm of π as a single-precision floating-point number.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 5, 2024
@vivekmaurya001 vivekmaurya001 changed the title Float32/ln pi feat: add constants/float32/ln-pi Dec 5, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 5, 2024

Coverage Report

Package Statements Branches Functions Lines
constants/float32/ln-pi $\color{green}48/48$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}48/48$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Dec 13, 2024

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 13, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @vivekmaurya001.

@kgryte kgryte added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Dec 13, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float32/ln-pi`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3342
Closes: https://github.com/stdlib-js/stdlib/issues/3344

Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Vivek Maurya <vm8118134@gmail.com>
Co-authored-by: Vivek maurya <155618190+vivekmaurya001@users.noreply.github.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit fc8571d into stdlib-js:develop Dec 13, 2024
19 checks passed
@vivekmaurya001 vivekmaurya001 deleted the float32/ln-pi branch January 1, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/ln-pi

3 participants