Skip to content

Conversation

@mfantham
Copy link
Contributor

@mfantham mfantham commented Aug 10, 2020

On Windows, the postinstall script causes the package.json of any project depending on @stdlib/stdlib to end up with a bunch of "\\" in the dependency names, which breaks npm install after the first installation.

Resolves #351 .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes running npm install on Windows when @stdlib/stdlib is a package dependency

Related Issues

Does this pull request have any related issues?

No.

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


@stdlib-js/reviewers

On Windows, package.json ends up with a bunch of "\\" in the dependencies, which breaks npm install after the first installation. This should fix that.
@kgryte
Copy link
Member

kgryte commented Aug 10, 2020

LGTM. I'll try to publish a new release in the coming days.

@kgryte kgryte merged commit af86c92 into stdlib-js:develop Aug 10, 2020
@mfantham
Copy link
Contributor Author

mfantham commented Nov 2, 2020

@kgryte any update on when a new release will get published? 🙂

@kgryte
Copy link
Member

kgryte commented Nov 2, 2020

Ah! Sorry. I can publish a new version later today.

@kgryte
Copy link
Member

kgryte commented Nov 2, 2020

Thanks for the nudge!

@kgryte
Copy link
Member

kgryte commented Dec 7, 2020

New release published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error running npm install on Windows when @stdlib/stdlib is a dependency

2 participants