Skip to content

Conversation

@DivyanshuVortex
Copy link
Contributor

Resolves #8488 .

Description

This RFC proposes adding the package symbol/split.

The package should be very similar to the following existing packages:

symbol/has-instance
symbol/iterator
symbol/async-iterator
symbol/is-concat-spreadable
The primary difference is that the package should export Symbol.split if it exists.

Related Issues
None.

Questions
No.

I have read and understood the Code of Conduct.

Searched for existing issues and pull requests.

The issue name begins with RFC:.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

Used ChatGPT for minor documentation and example formatting assistance.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 10, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 10, 2025

Coverage Report

Package Statements Branches Functions Lines
symbol/split $\color{green}124/124$
$color{green}+100.00%$
$\color{red}2/3$
$color{green}+66.67%$
$\color{green}0/0$
$color{green}+100.00%$
$\color{green}124/124$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 10, 2025

@DivyanshuVortex You'll need to resolve all CI failures before this PR can move forward. Cheers!

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 10, 2025
@kgryte
Copy link
Member

kgryte commented Nov 10, 2025

@DivyanshuVortex Quick tip: you'll accelerate your development cycle by following the project contributing guidelines and setting up your local dev environment. All the tests, linting, benchmarks, examples, etc, can all be run locally via make commands. This will help you avoid the need to constantly wait for CI to pass. As documented in the dev guide, we provide dev containers for VS Code to help folks get up and running.

@DivyanshuVortex
Copy link
Contributor Author

DivyanshuVortex commented Nov 10, 2025

Hey @kgryte, I tried running make lint locally but ran into dependency issues, and the dev container is using around 9–12 GB of RAM, which keeps crashing my system. I’m really sorry I couldn’t get it working smoothly. If you have a moment, I’d really appreciate any guidance on how to fix or optimize the setup.

If you prefer to close this , that’s totally fine — but please do share some guidance for resolving the linting setup if possible for upcoming contributes.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add symbol/split

3 participants