-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add ndarray/find-last
#8724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
headlessNode
wants to merge
1
commit into
stdlib-js:develop
Choose a base branch
from
headlessNode:ndarray-find-last
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,513
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,335 @@ | ||
| <!-- | ||
|
|
||
| @license Apache-2.0 | ||
|
|
||
| Copyright (c) 2025 The Stdlib Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
|
|
||
| --> | ||
|
|
||
| # findLast | ||
|
|
||
| > Return a new [ndarray][@stdlib/ndarray/ctor] containing the first elements which pass a test implemented by a predicate function along one or more [ndarray][@stdlib/ndarray/ctor] dimensions. | ||
|
|
||
| <section class="intro"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.intro --> | ||
|
|
||
| <section class="usage"> | ||
|
|
||
| ## Usage | ||
|
|
||
| ```javascript | ||
| var findLast = require( '@stdlib/ndarray/find-last' ); | ||
| ``` | ||
|
|
||
| #### findLast( x\[, options], predicate\[, thisArg] ) | ||
|
|
||
| Returns a new [ndarray][@stdlib/ndarray/ctor] containing the last elements which pass a test implemented by a predicate function along one or more [ndarray][@stdlib/ndarray/ctor] dimensions. | ||
|
|
||
| <!-- eslint-disable no-invalid-this, max-len --> | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 2.0 ], [ 3.0, 4.0 ] ], [ [ 5.0, 6.0 ], [ 7.0, 8.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast( x, isEven ); | ||
| // returns <ndarray> | ||
|
|
||
| var v = out.get(); | ||
| // returns 8.0 | ||
| ``` | ||
|
|
||
| The function accepts the following arguments: | ||
|
|
||
| - **x**: input [ndarray][@stdlib/ndarray/ctor]. | ||
| - **options**: function options _(optional)_. | ||
| - **predicate**: predicate function. | ||
| - **thisArg**: predicate function execution context _(optional)_. | ||
|
|
||
| The function accepts the following options: | ||
|
|
||
| - **dims**: list of dimensions over which to perform a reduction. | ||
| - **keepdims**: boolean indicating whether the reduced dimensions should be included in the returned [ndarray][@stdlib/ndarray/ctor] as singleton dimensions. Default: `false`. | ||
| - **sentinelValue**: value to return when no element passes the test. May be either a scalar value or a zero-dimensional [ndarray][@stdlib/ndarray/ctor]. | ||
|
|
||
| By default, the function performs reduction over all all elements in a provided [ndarray][@stdlib/ndarray/ctor]. To reduce specific dimensions, set the `dims` option. | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 2.0 ], [ 3.0, 4.0 ] ], [ [ 5.0, 6.0 ], [ 7.0, 8.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| var opts = { | ||
| 'dims': [ 0 ] | ||
| }; | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast( x, opts, isEven ); | ||
| // returns <ndarray> | ||
|
|
||
| var v = ndarray2array( out ); | ||
| // returns [ [ 8.0, NaN ], [ 6.0, NaN ] ] | ||
| ``` | ||
|
|
||
| By default, the function returns an [ndarray][@stdlib/ndarray/ctor] having a shape matching only the non-reduced dimensions of the input [ndarray][@stdlib/ndarray/ctor] (i.e., the reduced dimensions are dropped). To include the reduced dimensions as singleton dimensions in the output [ndarray][@stdlib/ndarray/ctor], set the `keepdims` option to `true`. | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 2.0 ], [ 3.0, 4.0 ] ], [ [ 5.0, 6.0 ], [ 7.0, 8.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| var opts = { | ||
| 'dims': [ 0 ], | ||
| 'keepdims': true | ||
| }; | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast( x, opts, isEven ); | ||
| // returns <ndarray> | ||
|
|
||
| var v = ndarray2array( out ); | ||
| // returns [ [ [ 8.0, NaN ], [ 6.0, NaN ] ] ] | ||
| ``` | ||
|
|
||
| To specify a custom sentinel value to return when no element passes the test, set the `sentinelValue` option. | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 3.0 ], [ 5.0, 7.0 ] ], [ [ 9.0, 11.0 ], [ 13.0, 15.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| var opts = { | ||
| 'sentinelValue': -999 | ||
| }; | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast( x, opts, isEven ); | ||
| // returns <ndarray> | ||
|
|
||
| var v = out.get(); | ||
| // returns -999 | ||
| ``` | ||
|
|
||
| To set the `predicate` function execution context, provide a `thisArg`. | ||
|
|
||
| <!-- eslint-disable no-invalid-this --> | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
|
|
||
| function isEven( value ) { | ||
| this.count += 1; | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 2.0 ], [ 3.0, 4.0 ] ], [ [ 5.0, 6.0 ], [ 7.0, 8.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| var ctx = { | ||
| 'count': 0 | ||
| }; | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast( x, isEven, ctx ); | ||
| // returns <ndarray> | ||
|
|
||
| var v = out.get(); | ||
| // returns 8.0 | ||
|
|
||
| var count = ctx.count; | ||
| // returns 1 | ||
| ``` | ||
|
|
||
| #### findLast.assign( x, out\[, options], predicate\[, thisArg] ) | ||
|
|
||
| Finds the last elements which pass a test implemented by a predicate function along one or more [ndarray][@stdlib/ndarray/ctor] dimensions and assigns results to a provided output [ndarray][@stdlib/ndarray/ctor]. | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var empty = require( '@stdlib/ndarray/empty' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 2.0 ], [ 3.0, 4.0 ] ], [ [ 5.0, 6.0 ], [ 7.0, 8.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| // Create an output ndarray: | ||
| var y = empty( [], { | ||
| 'dtype': x.dtype | ||
| }); | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast.assign( x, y, isEven ); | ||
| // returns <ndarray> | ||
|
|
||
| var bool = ( out === y ); | ||
| // returns true | ||
|
|
||
| var v = y.get(); | ||
| // returns 8.0 | ||
| ``` | ||
|
|
||
| The function accepts the following arguments: | ||
|
|
||
| - **x**: input [ndarray][@stdlib/ndarray/ctor]. | ||
| - **out**: output [ndarray][@stdlib/ndarray/ctor]. | ||
| - **options**: function options _(optional)_. | ||
| - **predicate**: predicate function. | ||
| - **thisArg**: predicate function execution context _(optional)_. | ||
|
|
||
| The function accepts the following options: | ||
|
|
||
| - **dims**: list of dimensions over which to perform a reduction. | ||
| - **sentinelValue**: value to return when no element passes the test. May be either a scalar value or a zero-dimensional [ndarray][@stdlib/ndarray/ctor]. | ||
|
|
||
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var empty = require( '@stdlib/ndarray/empty' ); | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 2.0 ], [ 3.0, 4.0 ] ], [ [ 5.0, 6.0 ], [ 7.0, 8.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| // Create an output ndarray: | ||
| var y = empty( [ 2, 2 ], { | ||
| 'dtype': x.dtype | ||
| }); | ||
|
|
||
| var opts = { | ||
| 'dims': [ 0 ] | ||
| }; | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast.assign( x, y, opts, isEven ); | ||
|
|
||
| var bool = ( out === y ); | ||
| // returns true | ||
|
|
||
| var v = ndarray2array( y ); | ||
| // returns [ [ 8.0, NaN ], [ 6.0, NaN ] ] | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.usage --> | ||
|
|
||
| <section class="notes"> | ||
|
|
||
| ## Notes | ||
|
|
||
| - By default, when no `sentinelValue` is provided, the function returns a default sentinel value based on the input [ndarray][@stdlib/ndarray/ctor] [data-type][@stdlib/ndarray/dtypes]: | ||
|
|
||
| - real-valued floating-point data types: `NaN`. | ||
| - complex-valued floating-point data types: `NaN + NaNj`. | ||
| - integer data types: maximum value. | ||
| - boolean data types: `false`. | ||
|
|
||
| - The `predicate` function is provided the following arguments: | ||
|
|
||
| - **value**: current array element. | ||
| - **indices**: current array element indices. | ||
| - **arr**: the input [ndarray][@stdlib/ndarray/ctor]. | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.notes --> | ||
|
|
||
| <section class="examples"> | ||
|
|
||
| ## Examples | ||
|
|
||
| <!-- eslint no-undef: "error" --> | ||
|
|
||
| ```javascript | ||
| var uniform = require( '@stdlib/random/uniform' ); | ||
| var isPositive = require( '@stdlib/assert/is-positive-number' ).isPrimitive; | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
| var findLast = require( '@stdlib/ndarray/find-last' ); | ||
|
|
||
| var x = uniform( [ 2, 4, 5 ], -10.0, 10.0, { | ||
| 'dtype': 'float64' | ||
| }); | ||
| console.log( ndarray2array( x ) ); | ||
|
|
||
| var y = findLast( x, isPositive ); | ||
| console.log( y.get() ); | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.examples --> | ||
|
|
||
| <!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> | ||
|
|
||
| <section class="related"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.related --> | ||
|
|
||
| <section class="links"> | ||
|
|
||
| [@stdlib/ndarray/ctor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/ctor | ||
|
|
||
| [@stdlib/ndarray/dtypes]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/dtypes | ||
|
|
||
| <!-- <related-links> --> | ||
|
|
||
| <!-- </related-links> --> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.links --> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgryte I think there may be a bug in
ndarray/findwhen passing a customsentinelValuein theoptionsobject. I'm not sure how the CI forndarray/findpassed and it's missing tests.I checked debugging
ndarray/findby modifying the example in theexamples/index.js, same thing. Could you confirm if there is indeed a bug inndarray/find? I'll then open a PR for it.