fix: constrain decorative code snippets to hero section#488
Open
nishtha-agarwal-211 wants to merge 2 commits into
Open
fix: constrain decorative code snippets to hero section#488nishtha-agarwal-211 wants to merge 2 commits into
nishtha-agarwal-211 wants to merge 2 commits into
Conversation
|
@nishtha-agarwal-211 is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces a dedicated .hero-section wrapper and styling so that absolutely positioned decorative elements (background + floating code snippets) are constrained to the landing-page hero, preventing overlap into the projects section.
Changes:
- Wraps the hero DOM content in a new
<section class="hero-section">container. - Restores/enables the
.hero-sectionCSS (positioning + overflow clipping) and adjusts hero padding. - Lowers decorative code snippet opacity values to reduce visual clutter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web-app/index.html | Wrapes hero elements in a .hero-section container to constrain decorative positioning. |
| web-app/css/styles.css | Enables .hero-section styling (relative + overflow hidden) and tunes snippet opacity/padding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
Fixes #474
DOM Restructure
.hero-background,.hero-code-snippets,.container) inside a.hero-sectioncontainer inweb-app/index.html.CSS Fix
.hero-sectioninweb-app/css/styles.csswith:position: relativeoverflow: hiddenThis constrains all absolutely positioned decorative elements within the hero section and prevents overlap with the projects section.
Visual Improvements
0.5/0.42to a subtle0.15 - 0.22range for improved readability and reduced visual clutter.JavaScript Fix
.hero-sectionto resolve theIntersectionObserverconsole error inmain.js.How to test
IntersectionObservererrors.