Make ship serve local attempt to serve everything#466
Merged
Conversation
Contributor
douglas-reid
left a comment
There was a problem hiding this comment.
nits and questions.
douglas-reid
previously approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
ships serve localwill now attempt to load up every option by default. The goal is to have a single command to suggest to people that always works:ship serve localBehaviors:
logs/shiplog-datetime.logfile is used for all other logging messagesLimitation:
/promptmethod to ALL AgentService objects. It will not work with older AgentService objects./prompt404 and tries/answer, remembering that worked if soAssumption:
This depends upon the PR to be merged with
ship server local->ship run local.How to test
Just use
pip install -e path/to/steamship-pythonand then.venv/bin/ship serve localinside an agent project.