Skip to content

Make ship serve local attempt to serve everything#466

Merged
eob merged 29 commits into
mainfrom
tb/http-repl
Jul 13, 2023
Merged

Make ship serve local attempt to serve everything#466
eob merged 29 commits into
mainfrom
tb/http-repl

Conversation

@eob
Copy link
Copy Markdown
Contributor

@eob eob commented Jul 11, 2023

Running ships serve local will now attempt to load up every option by default. The goal is to have a single command to suggest to people that always works: ship serve local

image

Behaviors:

  • Logging is limited to warning and errors in the console
  • A logs/shiplog-datetime.log file is used for all other logging messages
  • A repl, local server, ngrok server, and web UI are all started simuiltaneously
  • Options to suppress any of those startups are provided as command line args

Limitation:

  • The REPL depends upon the latest python-client code which adds a /prompt method to ALL AgentService objects. It will not work with older AgentService objects.
    • Suggested followup: A second PR catches the /prompt 404 and tries /answer, remembering that worked if so

Assumption:

This depends upon the PR to be merged with ship server local -> ship run local.

How to test

Just use pip install -e path/to/steamship-python and then .venv/bin/ship serve local inside an agent project.

@eob eob requested a review from EniasCailliau July 11, 2023 06:11
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits and questions.

Comment thread src/steamship/cli/cli.py Outdated
Comment thread src/steamship/cli/cli.py Outdated
Comment thread src/steamship/cli/cli.py Outdated
Comment thread src/steamship/cli/cli.py Outdated
Comment thread src/steamship/agents/service/agent_service.py Outdated
douglas-reid
douglas-reid previously approved these changes Jul 13, 2023
EniasCailliau
EniasCailliau previously approved these changes Jul 13, 2023
Copy link
Copy Markdown
Contributor

@EniasCailliau EniasCailliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eob eob dismissed stale reviews from EniasCailliau and douglas-reid via f998ac2 July 13, 2023 18:55
@eob eob merged commit f11baee into main Jul 13, 2023
@eob eob deleted the tb/http-repl branch July 13, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants