fix(agent): don't add blocks that contain only punctuation#469
Merged
Conversation
dkolas
previously approved these changes
Jul 12, 2023
Contributor
dkolas
left a comment
dkolas
left a comment
There was a problem hiding this comment.
Looks good. One question below. I'm good either way, just whatever you think best.
|
|
||
| # TODO(dougreid): extract shared bits from this and the ReACT output parser into a utility? | ||
| def is_punctuation(text: str): | ||
| return text in string.punctuation |
Contributor
There was a problem hiding this comment.
Do you want this to return true if ALL the text is punctuation, or only if it is a single character of punctuation? The current implementation does the latter:
>>> s = ".."
>>> import string
>>> s in string.punctuation
False
Contributor
Author
There was a problem hiding this comment.
good point. updated. still doesn't filter strings like .... .... ..., but that is so degenerate a case that I'm not sure we need to worry about it.
douglas-reid
force-pushed
the
doug/block-parsing
branch
from
88528d1 to
de91350
Compare
Contributor
Author
|
PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailing punctuation blocks are of little to no value (imho). This PR ensures that we don't add those blocks.
From:
To: