fix(test): attempt to deflake 'test_telegram' in staging#476
Merged
Conversation
dkolas
approved these changes
Jul 14, 2023
Contributor
dkolas
left a comment
dkolas
left a comment
There was a problem hiding this comment.
This is fine for the moment.
Staging has a build deployed that fixes the bug with URL-encoded GET params, which is why the behavior is now different in staging. Once that build is on prod as well, we'll only need the one version of this. Sorry I didn't catch it when I deployed the other build.
Contributor
Author
SG. Filed SHIP-770 to track. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in Staging environments, the URL encoding isn't happening (or isn't always happening?). In any case, this attempts to allow flexible results.