fix(tests): add retries to model checkpoint test#486
Merged
Conversation
douglas-reid
commented
Jul 14, 2023
douglas-reid
force-pushed
the
doug/fix-model-checkpoint-save-load-flake
branch
from
c4f33f3 to
9c60c28
Compare
douglas-reid
changed the title
douglas-reid
force-pushed
the
doug/fix-model-checkpoint-save-load-flake
branch
from
9c60c28 to
a08805d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a test flake around DEFAULT checkpoints when multiple test runs happen at the same time. This PR is an attempt to solve that by attempting to rerun the checks until the hashes match.
I don't know if that's the best way to handle this issue, but it was all I could think of at the moment. Someone with a deeper understanding of the intended behavior here could possibly come up with a better solution.