Skip to content

Support engine-registered development runs in the client#512

Merged
eob merged 6 commits into
mainfrom
full-localhost-run
Aug 14, 2023
Merged

Support engine-registered development runs in the client#512
eob merged 6 commits into
mainfrom
full-localhost-run

Conversation

@eob
Copy link
Copy Markdown
Contributor

@eob eob commented Aug 8, 2023

  • Fix response unpacking bug in local_server -- It should have been unwrapping the Service response like the Steamship Proxy
  • Fix the HttpREPL, which depended upon the improperly unwrapped response (see above)
  • Upon ship run local, register the local running NGROK URL with the Engine so that it can make async callbacks to it.

dkolas
dkolas previously approved these changes Aug 8, 2023
Copy link
Copy Markdown
Contributor

@dkolas dkolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues so far! Exciting stuff :)

@eob eob changed the title WIP: Support engine-registered development runs in the client Support engine-registered development runs in the client Aug 10, 2023
Copy link
Copy Markdown
Contributor

@dkolas dkolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eob eob enabled auto-merge August 14, 2023 21:03
@eob eob added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 07996f8 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants