Skip to content

bugfix: ship run local fails with --no-ngrok flag#536

Merged
eob merged 1 commit intomainfrom
ted/ship-839--no-ngrok-cli-flag-leads-to-referencing-a-variable-before-it
Aug 30, 2023
Merged

bugfix: ship run local fails with --no-ngrok flag#536
eob merged 1 commit intomainfrom
ted/ship-839--no-ngrok-cli-flag-leads-to-referencing-a-variable-before-it

Conversation

@eob
Copy link
Copy Markdown
Contributor

@eob eob commented Aug 29, 2023

The locally running package was attempting to adopt an instance handle from a non-extant Engine response.

In the event that --no-ngrok is specified, this PR assigns the locally running package a fixed constant handle intended to be clearly identified (in debugging logs) as a disconnected locally running copy.

@eob eob requested a review from dkolas August 29, 2023 20:19
@eob eob merged commit 0045906 into main Aug 30, 2023
@eob eob deleted the ted/ship-839--no-ngrok-cli-flag-leads-to-referencing-a-variable-before-it branch August 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants