Skip to content

feat: ship run local to only ask for a param value if there's available value, including default#542

Merged
eob merged 6 commits intomainfrom
dont-ask-cli-if-default
Sep 12, 2023
Merged

feat: ship run local to only ask for a param value if there's available value, including default#542
eob merged 6 commits intomainfrom
dont-ask-cli-if-default

Conversation

@eob
Copy link
Copy Markdown
Contributor

@eob eob commented Sep 1, 2023

Right now, the ship run local user must positively affirm each default value in configs.

This sets behavior to automatically use defaulted values, leaving the user with the -c config.json option to override defaults.

@eob eob requested a review from dkolas September 6, 2023 14:30
@eob
Copy link
Copy Markdown
Contributor Author

eob commented Sep 6, 2023

@dkolas I think you initially added this feature.

Right now the CLI asks the user to input any ConfigTemplate field that is (1) empty, but (2) defaulted.

That means to run some things locally, you have to press every time you type ship run local

This PR isn't any more right.. it's just a proposed tradeoff: if there's a default value applied, and you're doing ship run local, then it just accepts the default value as The Value.

Were a user to want to override it, they would supply the -c params.json arg

What do you think?

Copy link
Copy Markdown
Contributor

@dkolas dkolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent on this one. It's for local debugging, so the dev presumably knows what they did and didn't add defaults for. If you feel like this way is more convenient, go for it!

@eob eob merged commit 959e140 into main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants