New runs should exist in their own workspace#560
Merged
douglas-reid merged 3 commits intomainfrom Sep 27, 2023
Merged
Conversation
GitOnUp
approved these changes
Sep 27, 2023
Contributor
GitOnUp
left a comment
GitOnUp
left a comment
There was a problem hiding this comment.
LGTM with one QOL suggestion
| workspace_obj = Workspace.get(client) | ||
| # Create a new workspace if none was specified. | ||
| # Otherwise multiple runs co-mingle data in the `default` workspace. | ||
| workspace_obj = Workspace.create(client) |
Contributor
There was a problem hiding this comment.
Is this namespaced at all to the package/instance that's being used? It just might be harder to clean up your steamship workspace later without that mapping.
Something like appending the unix ts could help (or a random string suffix that also checks against collision).
douglas-reid
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GitOnUp mentioned this was really surprising to him, and it does feel like bug:
Unless a workspace is specified,
ship run localwill always run the agent in thedefaultworkspace which means the data and chat histories from multiple runs will be commingled.This PR: