Skip to content

fix(agents): ensure proper messaging and tool serialization#568

Merged
douglas-reid merged 2 commits intomainfrom
doug/debug-duplicate-messages
Sep 29, 2023
Merged

fix(agents): ensure proper messaging and tool serialization#568
douglas-reid merged 2 commits intomainfrom
doug/debug-duplicate-messages

Conversation

@douglas-reid
Copy link
Copy Markdown
Contributor

In an investigation into somewhat random duplicate message issues, we uncovered a few small issues that this PR cleans up:

  • don't repeat the user prompt
  • use proper JSON serialization of tools
  • catch improper JSON serialization coming back from OpenAI.

@douglas-reid douglas-reid requested a review from eob September 29, 2023 21:17
Copy link
Copy Markdown
Contributor

@eob eob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eob eob enabled auto-merge September 29, 2023 21:28
@eob eob added this pull request to the merge queue Sep 29, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 29, 2023
@douglas-reid douglas-reid added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit f659229 Sep 29, 2023
@douglas-reid douglas-reid deleted the doug/debug-duplicate-messages branch September 29, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants