Added handling for the colon character #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common to group commands into namespaces by using a colon in the command name to separate them. However standard bash completion treats the colon as a wordbreak (useful for ssh/scp) This change allows bash completion to work with commands including a colon character Based on the answer from this stack overflow quetion: http://stackoverflow.com/questions/10528695/how-to-reset-comp-wordbreaks-without-effecting-other-completion-script
stecman
added a commit
that referenced
this pull request
Jul 13, 2014
The CompletionHandler class was handling both completion and setting up the command/words to complete for. CompletionHandler now takes a CompletionContext in its constructor, which provides the command and words to complete for. Additionally: * Replaced use of the COMP_WORDBREAKS variable with a set of break characters more suited to parsing Symfony console application command-lines. This was needed for the colon character fix from #1 to work properly, as previously ':' was still in COMP_WORDBREAKS so was used to split a command up. * Added unit tests for CompletionContext
Owner
|
Thanks for your contribution @duncan3dc. I've been considering refactoring this module for a while, as it was originally thrown together quite quickly. Your PR inspired me to put some more work into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common to group commands into namespaces by using a colon in the command name to separate them.
However standard bash completion treats the colon as a wordbreak (useful for ssh/scp)
This change allows bash completion to work with commands including a colon character
Based on the answer from this stack overflow quetion:
http://stackoverflow.com/questions/10528695/how-to-reset-comp-wordbreaks-without-effecting-other-completion-script