Show authors in growth & estimation table. Rework estimation logic. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay - Implemented GetCumulativeUniqueAuthorsByYear to calculate unique authors per year. - Updated repository information to include total authors. - Modified growth history display to show authors alongside commits and on-disk size. - Adjusted tests to reflect changes in growth statistics structure and output.
… and git packages
…, enhance output formatting, and update tests for clarity
… improved alignment and readability
…ned values and update test expectations for clarity
…output for improved readability
…ive and negative values
… predictive accuracy. Replace old estimation logic with a dynamic approach based on delta changes. Update related display functions and tests accordingly.
…rcentage values. Update display functions and tests to utilize pre-computed values for improved clarity and consistency.
…stimates. Update logic to store these values for improved tracking and prediction.
…owth sections. Replace redundant functions with `DisplayUnifiedGrowth` for simplified logic and enhanced clarity.
…ed display logic. Update `DisplayUnifiedGrowth` to remove redundant header printing.
…implified formatting and reduced redundancy in printed output.
…tralization and clarity. Update `DisplayUnifiedGrowth` to reflect this change.
…columns. Adjust footnotes and spacing accordingly.
…ar column for clarity, adjust spacing in output, and update current year display to include markers for estimated growth.
…r for improved readability.
steffen
force-pushed
the
show-authors-in-growth-table
branch
from
e18f1a1 to
06fea8f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the growth and estimation display by adding author tracking and implementing a unified table showing both historic and estimated growth with enhanced delta percentage calculations.
- Adds cumulative author tracking across repository history
- Removes old estimation logic and implements new delta-based prediction algorithm
- Consolidates historic growth and estimation into a single unified table with enhanced formatting
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/progress/progress.go | Updates progress display format to show authors and placeholder values |
| pkg/models/models.go | Adds TotalAuthors field and comprehensive delta/percentage tracking fields |
| pkg/git/git_test.go | Removes outdated CalculateEstimate test function |
| pkg/git/git.go | Removes CalculateEstimate function and adds GetCumulativeUniqueAuthorsByYear |
| pkg/display/sections/run_information.go | Extends section header length for consistent formatting |
| pkg/display/sections/growth_tables_test.go | Updates tests to reflect new table structure and author tracking |
| pkg/display/sections/growth_history.go | Replaces historic growth display with unified table format |
| pkg/display/sections/growth_estimates.go | Implements new estimation algorithm and unified display function |
| main.go | Restructures growth calculation flow and integrates author tracking |
| fixtures/git-metrics.txt | Updates test fixture to reflect new unified table output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.