fix(budget-sources): stack lines panel below source info + add item links#1269
Merged
Conversation
- Restructure source row so SourceBudgetLinePanel renders as a full- width block below the header (info + actions), not in a column beside them. New .sourceRowHeader wraps the horizontal content. - Parent item names in the lines panel are now links to their detail page (/project/work-items/:id or /project/household-items/:id). - Add 2 unit tests for the new hyperlinks; wrap panel tests in MemoryRouter + LocaleProvider. Co-Authored-By: Claude frontend-developer (Haiku) <noreply@anthropic.com>
Contributor
|
Thank you for your submission! We require all contributors to sign our Contributor License Agreement before we can accept your contribution. I have read the CLA Document and I hereby sign the CLA Frank Steiler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
- Remove the jest.unstable_mockModule for react-i18next — the dynamic import + requireActual created a second module instance that didn't share the i18next instance initialized by setupTests, so t() returned raw keys. Using the real module provides resolved strings. - Tighten sourceRow E2E POM selector from [class*="sourceRow"] to [class*="sourceRow_"] so it no longer matches the new .sourceRowHeader helper class introduced in this PR. Co-Authored-By: Claude qa-integration-tester (Sonnet 4.6) <noreply@anthropic.com> Co-Authored-By: Claude e2e-test-engineer (Sonnet 4.6) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User feedback on the just-landed mini-epic (#1245–#1248):
Changes
BudgetSourcesPage.tsx/ CSS — wrap info+actions in a new.sourceRowHeader; panel renders beneathSourceBudgetLinePanel.tsx/ CSS — render parent item names as<Link>to/project/work-items/:idor/project/household-items/:idMemoryRouter+LocaleProvider; 2 new tests for the hyperlinksTest plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com