fix(i18n): add missing translation keys and remove orphans (#1306)#1308
Conversation
…lator audit protocol Fixes 10 Tier-1 keys missing from both en and de locales, 9 Tier-2 keys missing from en only, 1 Tier-3 de key, and removes 3 orphaned keys no longer referenced in code. Affected namespaces: budget, diary, householdItems, schedule, settings, workItems (en); budget, dashboard, diary, householdItems, schedule, settings (de). Also adds a Full Coverage Audit protocol section to the translator agent definition to prevent recurrence of these gaps. Fixes #1306 Co-Authored-By: Claude dev-team-lead (Sonnet 4.6) <noreply@anthropic.com> Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com> Co-Authored-By: Claude translator (Sonnet 4.5) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Thank you for your submission! We require all contributors to sign our Contributor License Agreement before we can accept your contribution. I have read the CLA Document and I hereby sign the CLA Frank Steiler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
…r edits The previous commit accidentally reverted PR #1302's rename of `overview.costBreakdown.area.unassigned` from "Unassigned" back to "No Area". This caused 30+ CostBreakdownTable tests to fail on CI. Restoring the beta value. Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
steilerDev
left a comment
There was a problem hiding this comment.
[product-architect] APPROVE (posted as comment — cannot self-approve own PR)
Architecturally sound. Scope is limited to i18n dictionary JSON and translator agent notes — no namespace restructuring, no key renames that cross feature boundaries, no API/schema touchpoints.
Reviewed:
- Namespace placement of new keys is consistent with existing conventions (
budget.invoices.*,dashboard.cards.budgetSummary.*,schedule.milestones.detail.*,settings.*,diary.*,householdItems.*). Nothing leaks across features. - Key naming follows the established camelCase dotted-path pattern (e.g.,
subsidiesOversubscribed,inspectionOutcomeRequired,contactAdded/Updated/Deleted). - Orphan deletions (
budget.vendors.tableHeaders.actions,budget.form.buttons.delete,householdItems.table.headers.room) are internal cleanup and don't affect contract shapes elsewhere. overview.costBreakdown.area.unassignedregression fix is a straight restore — good catch.- EN/DE parity restored for the Area feature (Tier-2) — no architectural concern; Area is the structured dimension per ADR-028 and these keys belong in their respective feature namespaces.
No concerns. Pre-existing E2E failures on beta (Budget Sources) are unrelated to this PR.
Summary
enanddelocales, 9 Tier-2 keys missing fromenonly, and 1 Tier-3dekey across the budget, diary, householdItems, schedule, settings, and workItems namespacesde, 1 fromen)Fixes #1306
Test plan
missing_in_en=0andmissing_in_de=0for the keys in scope for this fix🤖 Generated with Claude Code