Skip to content

fix(budget): print polish — page margins, title spacing, nested group boxes (#1325)#1326

Merged
steilerDev merged 1 commit into
betafrom
fix/1325-print-polish-boxes
Apr 20, 2026
Merged

fix(budget): print polish — page margins, title spacing, nested group boxes (#1325)#1326
steilerDev merged 1 commit into
betafrom
fix/1325-print-polish-boxes

Conversation

@steilerDev
Copy link
Copy Markdown
Owner

Summary

  • Per-page top/bottom margins via @page { margin: 1.5cm 1cm } (works on continuation pages; replaces first-page-only body { padding } approach)
  • Reduced top spacing before page h1 in print via PageLayout @media print overrides
  • Nested grayscale visual group boxes: outer medium-gray rectangle around each area + all descendants; inner light-gray rectangle around each item + its budget lines. Uses :has() selectors for bottom edges and box-shadow: inset for inner edges.

Fixes #1325

Test plan

  • Unit tests pass (95%+ coverage)
  • Integration tests pass
  • Pre-commit hook quality gates pass

Co-Authored-By: Claude dev-team-lead (Sonnet 4.6) noreply@anthropic.com
Co-Authored-By: Claude frontend-developer (Haiku 4.5) noreply@anthropic.com

… boxes

- Per-page top/bottom margins via `@page { margin: 1.5cm 1cm }` (works on continuation pages; replaces first-page-only `body { padding }` approach)
- Reduced top spacing before page h1 in print via PageLayout `@media print` overrides
- Nested grayscale visual group boxes: outer medium-gray rectangle around each area + all descendants; inner light-gray rectangle around each item + its budget lines. Uses `:has()` selectors for bottom edges and `box-shadow: inset` for inner edges.

Fixes #1325

Co-Authored-By: Claude dev-team-lead (Sonnet 4.6) <noreply@anthropic.com>
Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your submission! We require all contributors to sign our Contributor License Agreement before we can accept your contribution.

To sign, please comment on this PR with:
I have read the CLA Document and I hereby sign the CLA


I have read the CLA Document and I hereby sign the CLA


Frank Steiler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@steilerDev steilerDev merged commit f9a3c8a into beta Apr 20, 2026
29 of 34 checks passed
@steilerDev steilerDev deleted the fix/1325-print-polish-boxes branch April 20, 2026 07:58
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant