fix(budget): include quotations in actualCost and populate vendor fields on invoiceLink

[steilerDev]

Summary

Implements ADR-029 backend changes for handling quotations and vendor denormalization:

• actualCost now includes quotations: Removes quotation status filtering from actual cost aggregation in depositAggregateUtils and budgetOverviewService
• Vendor denormalization on invoiceLink: Adds vendorId and vendorName fields to BudgetLineInvoiceLink DTO via SQL joins in all invoice link query paths

Changes

Aggregate mutations:

• depositAggregateUtils.ts: Removed quotation skip check; actualCost now includes all invoice statuses
• budgetOverviewService.ts: Removed WHERE i.status != 'quotation' filter from actualCost query

Vendor denormalization:

• budgetServiceFactory.ts: Added vendor LEFT JOIN and fields to getInvoiceLink() and resolveRelationsBatch() invoice link queries
• workItemBudgetService.ts and householdItemBudgetService.ts: Propagate vendorId/vendorName through invoiceLink DTO
• budgetSourceService.ts: Added vendor joins and fields to both getWorkItemLineInvoiceLink() and getHouseholdItemLineInvoiceLink()
• budget.test.ts: Updated test fixture with vendor fields

API Contract Compliance

✓ GET /api/work-items/:id/budgets → WorkItemBudgetLine.actualCost includes quotations
✓ GET /api/household-items/:id/budgets → HouseholdItemBudgetLine.actualCost includes quotations
✓ GET /api/budget-overview → BudgetOverview.actualCost includes quotations
✓ All invoice links now include vendorId and vendorName fields (may be null)

Test Impact

No new test files created (test fixture updated in shared types).
QA integration tests should verify:

• actualCost aggregation includes quotation invoices
• vendorId/vendorName populated correctly from linked invoices
• Null handling when invoice has no vendor

Fixes #1439, #1440, #1441

🤖 Generated with Claude Code

[steilerDev]

[security-engineer] Security review for PR #1442 — VAT double-uplift + quotation invoice fixes (#1439, #1440, #1441)

SQL Injection — PASS

All four new LEFT JOIN vendors v ON v.id = i.vendor_id joins appear inside Drizzle sql tagged-template literals. The invoiceBudgetIdColumn field is the only dynamic value and it is passed through sql.raw() from an internal enum-controlled string ('work_item_budget_id' / 'household_item_budget_id') — no user input reaches it. No raw string concatenation introduced.

Access Control Regression — PASS

Folding quotations into actualCost does not widen access. Quotation invoices already existed on budget lines that were already accessible to the authenticated user. The change alters aggregated arithmetic on data the user already owns; it does not expose any record from a different user scope.

PII / Vendor Name Exposure — PASS

vendorName is now returned in BudgetLineInvoiceLink on the work-item and household-item budget endpoints. Vendor names are already fully exposed via GET /api/vendors/:id and the vendor list endpoint — both established since EPIC-02. No new disclosure surface.

New Endpoints / Request Body Surface — PASS

Confirmed: no new routes, no new route schemas, and no new body validation surface. All changes are confined to the service layer and shared utilities.

VAT Fix (useBudgetSection.ts) — PASS

The removed client-side multiplier = includesVat ? 1 : 1.19 block was a double-application arithmetic bug, not a security concern. Removing it is correct; the single effective-amount calculation remains display-side only.

---

VERDICT: APPROVED

[steilerDev]

[ux-designer]

Reviewed InvoiceGroup.module.css, InvoiceGroup.tsx, and BudgetSection.tsx against the design system.

Token adherence — .vendorName uses var(--font-size-sm) and var(--color-text-secondary). Both are Layer 2 semantic tokens. No hardcoded hex, px, or rem literals in the new class. Clean.

Dark mode — --color-text-secondary maps to var(--color-gray-700) in light and var(--color-slate-150) in dark via the [data-theme="dark"] block in tokens.css. Automatic flip, no local dark override needed. Passes WCAG AA contrast on both --color-bg-primary surfaces.

Visual hierarchy — vendor name renders inside .invoiceInfo between the invoice number link and the status badge. The gap: 0.5rem flex row keeps the three elements close without crowding. The --font-size-sm (14px) sits one size below the 15px toggle button text (0.9375rem), creating a clear secondary-text visual weight. Acceptable hierarchy.

Responsive — at ≤767px, .headerContent already switches to flex-direction: column. .invoiceInfo stays as a flex row within that column, so the vendor name wraps horizontally with the invoice number and badge. At narrow widths (360px), a long vendor name could push the status badge to a new line inside .invoiceInfo. No truncation or max-width is applied. This is acceptable — the status badge and invoice number are white-space: nowrap, so they will not break; only the vendor name itself would wrap if very long. Not a blocking issue, but a overflow: hidden; text-overflow: ellipsis; max-width: 12rem on .vendorName at mobile would improve resilience.

Null handling — the JSX {vendorName && <span ...>} guard correctly suppresses the span when vendorName is null. The test suite explicitly verifies the "null" string does not appear in the DOM.

Accessibility — aria-label updated to Invoice X from Vendor: N budget lines, €amount. Reads naturally. The conditional from ${vendorName} is omitted when null, preserving the existing label shape.

---

VERDICT: APPROVED

One non-blocking suggestion: add overflow: hidden; text-overflow: ellipsis; max-width: 12rem; white-space: nowrap to .vendorName in a follow-up, or apply it inside the mobile breakpoint block, to guard against very long vendor names at 360px.

[steilerDev]

[product-architect] Reviewed against ADR-029 contract.

Contract compliance — verified

• actualCost now folds quotations: depositAggregateUtils.ts drops the quotation skip; budgetOverviewService.ts drops WHERE i.status != 'quotation'. Doc comment updated to ADR-029 wording.
• actualCostPaid invariant preserved: paid/claimed deposit splits unchanged; quotation residual still falls under status='quotation' → not paid. Subsidy-payback invariant intact.
• All four invoice-link query paths (getInvoiceLink, resolveRelationsBatch bulk, getWorkItemLineInvoiceLink, getHouseholdItemLineInvoiceLink) add LEFT JOIN vendors v ON v.id = i.vendor_id and propagate vendorId / vendorName through BudgetLineInvoiceLink.
• Tests: the pre-existing assertions at depositAggregateUtils.test.ts:81 and :220 are properly updated in place (now assert actualCost=250 / actualCost=200 with explicit ADR-029 comments) — not deleted. New regression coverage added for mixed quotation+paid and quotation+pending+claimed scenarios.
• Shared types and wiki unchanged after architect commit b0dda966 (only shared/src/types/budget.test.ts test fixture touched). Vendor fields typed as string | null consistently across DTO, SQL row types, and shared interface — no any.
• VAT fix (#1439): removed double *1.19 multiplier in useBudgetSection.handleSaveBudgetLine. Server stores raw net; effectivePlannedAmount applies the single uplift at display — matches the documented behaviour for includesVat=0.

No silent semantic drift elsewhere

• budgetSourceService.getWork/HouseholdItemLineInvoiceData already summed all statuses pre-change (only actualCostPaid filtered to paid/claimed) → already ADR-029-aligned.
• subsidyPaybackServiceFactory already aggregates all statuses.
• budgetBreakdownService per-line aggregation retains isQuotation flag for the ±5% projected bracket — unchanged and consistent with the new doc comment guiding consumers to apply CONFIDENCE_MARGINS.quote if they want uncertainty bracketing.
• No migration changes (correct — service/DTO-only change).

Note (non-blocking)

• E2E Gates is red (shards 4 + 15) but Quality Gates is green. Beta merge isn't gated on E2E Gates; promotion to main is. Worth a quick look at the failing shards before promotion.

VERDICT: APPROVED

[github-actions]

🎉 This PR is included in version 2.6.0-beta.16 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀