test(e2e): re-skip 2 print tests blocked on production bugs (#1450, #1451)#1453
Merged
Merged
Conversation
…1451 PR #1447 re-enabled all 4 budget-overview-print skips. Two of them are blocked by genuine production bugs that need separate fixes: - "Dark mode: print resets CSS variables to light values" — blocked on #1451 (`:global(@media print)` in CSS Module is silently dropped by the bundler). - "On-screen expansion state restored after afterprint" — blocked on #1450 (`usePrintExpansion` hook closure loses pre-print snapshot when the effect re-runs). Re-skip these two with explicit issue references so the rationale is discoverable and re-enable is a one-line change once each bug is fixed. Co-Authored-By: Claude e2e-test-engineer (Sonnet 4.6) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.6.0-beta.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-skips two budget-overview-print E2E tests that were enabled in PR #1447 but cannot pass until production bugs filed by that PR are fixed:
:global(@media print)in CSS Modules)usePrintExpansionclosure loses snapshot on effect re-run)Each
test.skiphas a 3-line comment with the issue reference and the root cause so re-enable is a one-line revert once the underlying bug ships.The other 2 tests re-enabled by PR #1447 (
'Print forces full expansion'and'Other pages are unaffected') remain enabled.Test plan
test.skipblocks have a leading// SKIP: Blocked on production bug #NNNNcommentCo-Authored-By: Claude e2e-test-engineer (Sonnet 4.6) noreply@anthropic.com