fix(photo-annotator): colour picker updates non-text shapes' stroke#1523
Merged
Conversation
The colour picker only updated text and callout shapes (which use a color field). Every other shape type stores the user-picked colour under stroke, so selecting a rectangle/arrow/line/ellipse/freehand/ measurement and picking a new colour silently changed nothing. The handler now writes either color or stroke based on shape.type. Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.6.0-beta.60 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The colour-picker handler only updated
textandcalloutshapes (which use acolorfield). Every other shape type (rectangle, highlight, arrow, line, ellipse, freehand, measurement) stores the user-picked colour understroke, so selecting one of those and picking a new colour silently did nothing.Fix: write
colorfor text/callout andstrokefor everything else.Test plan