[codex] Fix OpenAI costs parsing#1000
Closed
SergeyLavrentev wants to merge 1 commit into
Closed
Conversation
OpenAI organization costs responses may return amount.value as a numeric string. Decode both numeric and string values so Admin API usage does not fail parsing.
Owner
|
Thanks for the clean repro and patch. I landed the fix on Validation:
Closing this draft PR since the fix is now shipped on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amount.valuewhen it is returned as a numeric string.Fixes #999
Root cause
The OpenAI Costs API can return
amount.valueas a string such as"12.50".OpenAIAPIUsageFetcherdecoded this field asDouble?, so a successful HTTP 200 costs response failed JSON decoding and OpenAI Admin API usage rendered an error.Validation
/v1/organization/costswith an Admin API key decoded 31 cost buckets using the tolerant decoder.swift test --filter OpenAIAPICreditBalanceTestscould not complete in this local environment because only Command Line Tools are installed; the macOS test target pullsKeyboardShortcuts, whose SwiftUI#Previewusage requiresPreviewsMacrosfrom full Xcode.