perf: background credits and dashboard fetch for regular refreshes#1078
Open
ptstory wants to merge 2 commits into
Open
perf: background credits and dashboard fetch for regular refreshes#1078ptstory wants to merge 2 commits into
ptstory wants to merge 2 commits into
Conversation
Move refreshCreditsIfNeeded() and refreshOpenAIDashboardIfNeeded() into background tasks for non-forced refreshes. Add Task?-based coalescing guard for credits refresh to prevent unbounded stacking. Forced refreshes (manual) still await inline. Split from steipete#1073.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55945600c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Persist widget snapshots when background Codex credits and OpenAI dashboard refresh tasks complete so widget state does not lag behind successful async refreshes. Add regression coverage proving widget snapshots update after backgrounded credits and dashboard fetch completion.
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background regular Codex web refreshes so the UI never blocks on slow network operations during the polling cycle. Add credits-refresh coalescing so repeated poll cycles cannot stack concurrent credits fetches.
Split from #1073 per review feedback. Related: #678.
What changed
For non-forced refreshes,
refreshCreditsIfNeeded()andrefreshOpenAIDashboardIfNeeded()now run in background tasks instead of blocking the regular refresh path. Credits refresh now uses aTask<Void, Never>?guard so a second poll skips starting another credits fetch while one is already in flight.Why
The regular refresh cycle was awaiting Codex credits and OpenAI dashboard web work inline, which could block the main thread for seconds during slow network scrapes. It also allowed repeated poll cycles to stack concurrent credits fetches without any coalescing.
How to verify
swift test --filter CodexManagedOpenAIWebRefreshTests ./Scripts/lint.sh format ./Scripts/lint.sh lint make checkNotable decisions
Task?reference instead of a boolean so the in-flight state is derived from the task itself.Not included