Fix OpenAI dashboard reset-line parser for Wednesday and Saturday#1080
Merged
steipete merged 2 commits intoMay 21, 2026
Conversation
OpenAIDashboardParser.weekdayMatch used the regex "\b(mon|tue|tues|wed|thu|thur|thurs|fri|sat|sun)(day)?\b" which relies on <abbrev> + optional "day" reproducing the full weekday name. That holds for monday/tuesday/thursday/friday/sunday (the layered "tue|tues" and "thu|thur|thurs" alternatives cover the longer ones), but "wed"+"day"="wedday" and "sat"+"day"="satday" — so "Wednesday" and "Saturday" in reset strings produced no match. parseResetDate then fell through to format-string parsing which can't recover bare weekday text either, dropping the reset time silently on 2 of every 7 days. Add "wednes" and "satur" alongside the existing alternatives, mirroring the same progressive-abbreviation pattern. New TestsLinux suite sweeps all seven full weekday names plus dedicated lowercase Wed/Sat regressions through the public parseRateLimits API; the parameterized test surfaces both regressions on master and goes green with the fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
steipete
force-pushed
the
fix/openai-dashboard-weekday-regex
branch
from
74719ef to
807982f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAIDashboardParser.weekdayMatch used the regex
"\b(mon|tue|tues|wed|thu|thur|thurs|fri|sat|sun)(day)?\b" which relies on + optional "day" reproducing the full weekday name. That holds for monday/tuesday/thursday/friday/sunday (the layered "tue|tues" and "thu|thur|thurs" alternatives cover the longer ones), but "wed"+"day"="wedday" and "sat"+"day"="satday" — so "Wednesday" and "Saturday" in reset strings produced no match. parseResetDate then fell through to format-string parsing which can't recover bare weekday text either, dropping the reset time silently on 2 of every 7 days.
Add "wednes" and "satur" alongside the existing alternatives, mirroring the same progressive-abbreviation pattern. New TestsLinux suite sweeps all seven full weekday names plus dedicated lowercase Wed/Sat regressions through the public parseRateLimits API; the parameterized test surfaces both regressions on master and goes green with the fix.