Fix provider sidebar trailing control spacing

[Yuxin-Qiao]

Summary

Adds a small trailing inset to provider sidebar rows so the enabled checkbox has enough breathing room from the scroll/list boundary and adjacent detail pane.

This is a layout-only fix for Settings > Providers and does not change provider logic, quota parsing, billing, or data behavior.

Validation

• swift build — passed
• ./Scripts/lint.sh lint — blocked by an unrelated SwiftFormat warning in Tests/CodexBarTests/StatusMenuSwitcherClickTests.swift (redundantAsync)

[clawsweeper]

Codex review: needs real behavior proof before merge. Reviewed May 27, 2026, 8:40 PM ET / 00:40 UTC.

Summary
The PR adds a trailing 6-point SwiftUI padding modifier to provider sidebar rows so the enabled checkbox has more space at the right edge.

Reproducibility: not applicable. this is a visual PR review rather than a bug report with a failing reproduction path. Source inspection confirms current main and v0.30.0 do not already contain the trailing inset.

Review metrics: 1 noteworthy metric.

• Changed surface: 1 SwiftUI file, 1 added line. The patch is a narrow visual layout change, so proof quality matters more than broad code risk.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

• Add an after-fix screenshot or short recording of Settings > Providers from a rebuilt app, with private provider/account details redacted.

Proof guidance:
Needs real behavior proof before merge: No after-fix screenshot, recording, terminal output, or redacted live output shows Settings > Providers from a rebuilt app; the contributor should add proof and update the PR body for re-review.

Mantis proof suggestion
A visible macOS settings layout change is well suited to independent visual proof if maintainers want it. A maintainer can ask Mantis to capture proof by posting a new PR comment that starts with the OpenClaw Mantis account mention, followed by:

visual task: verify Settings > Providers sidebar rows show comfortable trailing checkbox spacing in a rebuilt CodexBar app.

Risk before merge

• The PR changes visible macOS settings layout but includes no after-fix screenshot, recording, or live output from a rebuilt app, so the actual visual improvement is unproven.

Maintainer options:

1. Decide the mitigation before merge
   Keep the narrow padding change if rebuilt Settings > Providers visual proof confirms the checkbox spacing improves without making the row look cramped or misaligned.
2. Pause or close
   Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
This needs contributor-supplied real behavior proof and maintainer visual review, not an automated code repair.

Security
Cleared: The diff is a one-line SwiftUI layout change and does not touch security-sensitive or supply-chain surfaces.

Review details

Best possible solution:

Keep the narrow padding change if rebuilt Settings > Providers visual proof confirms the checkbox spacing improves without making the row look cramped or misaligned.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this is a visual PR review rather than a bug report with a failing reproduction path. Source inspection confirms current main and v0.30.0 do not already contain the trailing inset.

Is this the best way to solve the issue?

Likely yes; a small trailing inset on the existing row container is a narrow maintainable fix for checkbox breathing room. The missing piece is visual proof from the rebuilt UI, not a code repair.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 63d9373b733f.

Label changes

Label justifications:

• P3: This is low-risk settings UI polish with limited blast radius.
• rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
• status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: No after-fix screenshot, recording, terminal output, or redacted live output shows Settings > Providers from a rebuilt app; the contributor should add proof and update the PR body for re-review.

Evidence reviewed

What I checked:

• Current main source: Current main still closes the provider row HStack immediately after the small checkbox and then applies only contentShape plus vertical padding, so the requested trailing inset is not already present. (Sources/CodexBar/PreferencesProviderSidebarView.swift:107, 63d9373b733f)
• Latest release source: v0.30.0 has the same checkbox row without trailing padding, so the spacing change is not already shipped in the latest release. (Sources/CodexBar/PreferencesProviderSidebarView.swift:107, 81cf30a6d5e1)
• PR diff: The current PR diff modifies one file and adds .padding(.trailing, 6) after the ProviderSidebarRowView HStack. (Sources/CodexBar/PreferencesProviderSidebarView.swift:112, 381a0d860788)
• Proof check: The PR body lists swift build and a blocked lint run, and the only issue comment is the existing ClawSweeper needs-proof review; no after-fix screenshot, recording, or live output was posted. (381a0d860788)
• Repository UI review policy: AGENTS.md asks PRs to include screenshots/GIFs for UI changes and to validate UI/runtime behavior against a freshly built bundle, which applies to this visible settings layout change. (AGENTS.md:28, 63d9373b733f)
• History provenance: GitHub commit history for the provider sidebar file points to the provider pane redesign and later sidebar layout refinements as the relevant ownership trail. (Sources/CodexBar/PreferencesProviderSidebarView.swift:1, 90e608be824b)

Likely related people:

• steipete: Introduced the provider pane/sidebar redesign and made several later sidebar visual/layout refinements that define this settings row pattern. (role: feature owner; confidence: high; commits: 90e608be824b, a3b0f092dada, 171f3e55c91d; files: Sources/CodexBar/PreferencesProviderSidebarView.swift)
• chadneal: Authored the macOS Tahoe provider sidebar clipping/window-sizing fix that touched the same sidebar layout surface. (role: adjacent layout contributor; confidence: medium; commits: 1f3d5bd7ad33, ffe7ed03425c; files: Sources/CodexBar/PreferencesProviderSidebarView.swift)

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 028b004609

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Suppress the deferred icon render too

When a number-key provider shortcut is used with the merged menu open, switcherView.handleKeyboardSelection(at:) immediately runs the switcher's onSelect, which calls deferSwitcherMenuRebuildIfStillVisible; that task yields once, confirms the same menu is still in openMenus, and then rebuildOpenMenuIfStillVisible calls applyIcon(phase: nil) while the menu is still tracked. This new guard therefore only skips the extra direct render on line 117, but the status item can still change width one run-loop later in the exact keyboard-selection scenario this change is trying to prevent; the added test also checks before yielding so it misses this path.

Useful? React with 👍 / 👎.