Add Swedish localization#1186
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 28, 2026, 4:53 PM ET / 20:53 UTC. Summary Reproducibility: not applicable. this is a localization feature PR, not a bug report. The relevant verification is key parity, packaged-app localization proof, and maintainer wording review. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the Swedish localization after required checks are green and a maintainer is comfortable with the translation wording, keeping the existing enum-plus-resource-bundle localization pattern. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a localization feature PR, not a bug report. The relevant verification is key parity, packaged-app localization proof, and maintainer wording review. Is this the best way to solve the issue? Yes, the implementation is the narrow maintainable path: it adds a new AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 1115d2d63a78. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
eaee97b to
e9fc4eb
Compare
|
Updated the PR branch and added the missing behavior proof. What changed:
Validation:
Runtime proof copied from the packaged debug app with Swedish selected: @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
e9fc4eb to
84154de
Compare
Summary
sv) localization with fullLocalizable.stringscoveragemain(ca63a8e7) and refresh Swedish coverage for new upstream keysValidation
plutil -lint Sources/CodexBar/Resources/en.lproj/Localizable.strings Sources/CodexBar/Resources/sv.lproj/Localizable.stringsen=1025 sv=1025 missing=0 extra=0 placeholder_mismatches=0swift test --filter LocalizationBundleTestsmake checkCODEXBAR_SIGNING=adhoc ./Scripts/package_app.sh debugRuntime proof
Copied live output from the packaged debug app after selecting Swedish via
appLanguage=sv: