Add Codex system account reconciliation#616
Add Codex system account reconciliation#616ratulsarna merged 18 commits intocodex/rat-185-multi-account-foundationfrom
Conversation
|
@codex review |
ratulsarna
changed the title
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 056dd22160
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1efe895e3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ratulsarna
merged commit 62713e8
into
codex/rat-185-multi-account-foundation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9ab808104
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| snapshot.liveSystemAccount != nil ? .liveSystem : .managedAccount(id: id) | ||
| } |
There was a problem hiding this comment.
When the persisted source is a managed account that has been removed and no live system account is present, this branch keeps returning the stale .managedAccount(id) instead of resolving to one of the remaining stored accounts. That leaves codexResolvedActiveSource permanently pointed at a non-existent target, so Codex/OpenAI-web refreshes remain fail-closed as managedAccountTargetUnavailable even though a valid managed account still exists; if only one account remains, the settings UI shows no active picker, so the user has no in-app way to recover selection.
Useful? React with 👍 / 👎.
1 participant
Summary
It observes the live system Codex account read-only, reconciles it with CodexBar-added accounts, and exposes a visible account projection with a truthful active/live split.
It also adds regression coverage to keep remote routing and OpenAI web behavior pinned to the active account.